Page MenuHomePhabricator

docs: Fill-in docs for Efl.Threadio, Efl.Appthread
ClosedPublic

Authored by CHAN on Sep 17 2019, 9:37 PM.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
CHAN created this revision.Sep 17 2019, 9:37 PM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

CHAN requested review of this revision.Sep 17 2019, 9:37 PM

Is there any differences between EflThreadIOCall and EflThreadIOCallSync?
and I recommend to change from "Write" to "Writes" according to third person singular representation like "Sets/Gets".

stefan_schmidt added a subscriber: stefan_schmidt.EditedSep 18 2019, 1:04 AM

Off topic for review, but congrats to the 10000's differential to @CHAN ! :-)

segfaultxavi accepted this revision.Sep 18 2019, 4:42 AM

Thanks for filling-in these classes. I will update a few things in the next commit.

This revision is now accepted and ready to land.Sep 18 2019, 4:42 AM
Closed by commit rEFL04df2327bd9f: docs: Fill-in docs for Efl.Threadio, Efl.Appthread (authored by Woochanlee <wc0917.lee@samsung.com>, committed by segfaultxavi). · Explain WhySep 18 2019, 4:50 AM
This revision was automatically updated to reflect the committed changes.