Page MenuHomePhabricator

eolian_mono: add more verbs to generate C# method beginning with verb
ClosedPublic

Authored by lauromoura on Sep 18 2019, 1:13 AM.

Details

Summary

C# language binding generates C# method name beginning with verb by
checking verb list in name_helpers.hh.

Some verbs used in eo method are missing in the current verb list. So
they are added into the verb list.

In this scheme, there is a problem that some words can be used as a verb
in some methods but they also can be used as a noun in other methods.
(e.g. drag_start as a verb / cursor_word_start as a noun)

So "start" and "scroll" are not added to verb list in this patch.
To resolve the above problem, we may need a new eo syntax to rename or
reverse the name in language bindings.

Test Plan

Check C# method names in .eo.cs files if the name begins with verb.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Jaehyun_Cho created this revision.Sep 18 2019, 1:13 AM
Jaehyun_Cho requested review of this revision.Sep 18 2019, 1:13 AM
lauromoura commandeered this revision.Fri, Sep 20, 7:28 AM
lauromoura edited reviewers, added: Jaehyun_Cho; removed: lauromoura.

Looks good, but I'm commaneering to add some needed changes to manual MVVM code (s/PropertyBind/BindProperty/)

lauromoura updated this revision to Diff 25258.Fri, Sep 20, 7:29 AM

Update with manual MVVM fixes.

segfaultxavi accepted this revision.Fri, Sep 20, 10:22 AM
This revision is now accepted and ready to land.Fri, Sep 20, 10:22 AM
This revision was automatically updated to reflect the committed changes.