Page MenuHomePhabricator

ecore: correctly handle children removal in Efl.Composite_Model by updating all required index.
ClosedPublic

Authored by cedric on Sep 19 2019, 1:11 PM.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
cedric created this revision.Sep 19 2019, 1:11 PM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

cedric updated this revision to Diff 25272.Fri, Sep 20, 3:18 PM
cedric edited the summary of this revision. (Show Details)

rebase

cedric updated this revision to Diff 25281.Fri, Sep 20, 3:22 PM

phab!!!

bu5hm4n requested changes to this revision.Sat, Sep 21, 3:34 AM
bu5hm4n added inline comments.
src/lib/ecore/efl_composite_model.c
177

that must be sizeof(unsigned int)

This revision now requires changes to proceed.Sat, Sep 21, 3:34 AM
cedric updated this revision to Diff 25408.Mon, Sep 23, 4:07 PM

rebase and take comments into account

bu5hm4n accepted this revision.Mon, Sep 23, 11:54 PM
This revision is now accepted and ready to land.Mon, Sep 23, 11:54 PM
Closed by commit rEFL6e497527125e: ecore: correctly handle children removal in Efl.Composite_Model by updating all… (authored by cedric, committed by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyTue, Sep 24, 12:19 AM
This revision was automatically updated to reflect the committed changes.