Page MenuHomePhabricator

elementary: fix children removal in Efl.Ui.Select_Model by not remembering index and relying on underlayer infrastructure to do it for us.
ClosedPublic

Authored by cedric on Thu, Sep 19, 1:16 PM.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
cedric created this revision.Thu, Sep 19, 1:16 PM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

cedric requested review of this revision.Thu, Sep 19, 1:16 PM
cedric updated this revision to Diff 25291.Fri, Sep 20, 3:24 PM

phab!!!

bu5hm4n added inline comments.Sat, Sep 21, 3:47 AM
src/lib/elementary/efl_ui_select_model.c
458

Mhm, shoudnt this return some sort of id that indicates that there is no selection, EAGAIN sounds more like"there is a change in progress, try again after one iter"

cedric added inline comments.Sat, Sep 21, 7:15 AM
src/lib/elementary/efl_ui_select_model.c
458

Eagain in our mvvm infrastructure mean register a property change event and wait for it to become available which I think match this case as that's what the user should do.

bu5hm4n added inline comments.Mon, Sep 23, 8:53 AM
src/lib/elementary/efl_ui_select_model.c
458

Okay :)

cedric updated this revision to Diff 25418.Mon, Sep 23, 4:20 PM

rebase and take comment into account

This revision was not accepted when it landed; it landed in state Needs Review.Tue, Sep 24, 11:13 AM
This revision was automatically updated to reflect the committed changes.