elementary: fix children removal in Efl.Ui.Select_Model by not remembering index and relying on underlayer infrastructure to do it for us.
ClosedPublic
Actions

Authored by cedric on Sep 19 2019, 1:16 PM.

Details

Reviewers

bu5hm4n
zmike
lauromoura
segfaultxavi
SanghyeonLee
felipealmeida

Commits

rEFL832d300e2036: elementary: fix children removal in Efl.Ui.Select_Model by not remembering…

Summary

Depends on D9957

Diff Detail

Repository

rEFL core/efl

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

cedric created this revision.Sep 19 2019, 1:16 PM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

cedric requested review of this revision.Sep 19 2019, 1:16 PM

Harbormaster completed remote builds in B13426: Diff 25201.Sep 19 2019, 1:16 PM

cedric added a child revision: D9958: elementary: introduce Efl.Ui.CollectionView a generic listing View..Sep 19 2019, 1:17 PM

cedric added reviewers: bu5hm4n, zmike, lauromoura, segfaultxavi, SanghyeonLee, felipealmeida.Sep 20 2019, 9:38 AM

phab!!!

Harbormaster completed remote builds in B13488: Diff 25291.Sep 20 2019, 3:24 PM

bu5hm4n added inline comments.Sep 21 2019, 3:47 AM

src/lib/elementary/efl_ui_select_model.c
458	Mhm, shoudnt this return some sort of id that indicates that there is no selection, EAGAIN sounds more like"there is a change in progress, try again after one iter"

cedric added inline comments.Sep 21 2019, 7:15 AM

src/lib/elementary/efl_ui_select_model.c
458	Eagain in our mvvm infrastructure mean register a property change event and wait for it to become available which I think match this case as that's what the user should do.

bu5hm4n added inline comments.Sep 23 2019, 8:53 AM

src/lib/elementary/efl_ui_select_model.c
458	Okay :)

rebase and take comment into account

Harbormaster completed remote builds in B13568: Diff 25418.Sep 23 2019, 4:20 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 24 2019, 11:13 AM

Closed by commit rEFL832d300e2036: elementary: fix children removal in Efl.Ui.Select_Model by not remembering… (authored by cedric). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/lib/elementary/efl_ui_select_model.c (35 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	25201	34f87ed		Sep 19 2019, 1:16 PM	★	★
Diff 2	25291	31f7ca7	phab!!!	Sep 20 2019, 3:24 PM	★	★
Diff 3	25418	30bf51b	rebase and take comment into account	Sep 23 2019, 4:14 PM	★	★
Diff 4	25461	3c9a463	rEFL832d300e203621c9c32cb186fef16a529cc4306b	Sep 24 2019, 11:12 AM	★	★

Status	Author	Revision
Closed	bu5hm4n	D9970 efl_ui_position_manager_list: emit events correctly
Closed	bu5hm4n	D9969 efl_ui_collection_view: support focus
Closed	cedric	D10063 elementary: add a basic test for MVVM infrastructure.
Closed	cedric	D10062 efl: improve test in checking the return value during Eina_Value get operation.
Abandoned	cedric	D10061 elementary: Efl.Ui.Select_Model should actually use iterator_new as prefix for all iterator functions.
Closed	cedric	D9960 elementary: add Efl.Ui.Grid_View by leveraging MVVM and Collection/Position_Manager infrastructure.
Closed	cedric	D10035 elementary: migrate Efl.Ui.List_View to use Efl.Ui.Collection_View.
Closed	cedric	D9958 elementary: introduce Efl.Ui.CollectionView a generic listing View.
Closed	cedric	D10034 elementary: fix children removal in Efl.Ui.Select_Model by not remembering index and relying on underlayer infrastructure to do it for us.
Closed	cedric	D9957 elementary: add an interface for asynchronous multi selection.
Closed	cedric	D9956 elementary: factorize all events emitted by a Efl.Ui.Collection into their own interface.
Closed	cedric	D9955 efl: make Efl.Ui.Factory.release work in batches.
Closed	cedric	D9954 elementary: rework Efl.Ui.Factory to have another additional stage during releasing of items.
Closed	cedric	D9953 efl: simplify logic for widget created by factory.
Closed	cedric	D9952 efl: split Efl.Ui.Factory.create stage into constructing and building
Closed	cedric	D9951 elementary: Efl.Ui.Layout_Factory bind property during widget creation.
Closed	cedric	D9950 elementary: Efl.Ui.Image_Factory bind property also during widget creation.
Closed	cedric	D10033 ecore: update Efl.Boolean_Model to handle children removal and shifting all necessary boolean and index.
Closed	cedric	D10032 ecore: correctly handle children removal in Efl.Composite_Model by updating all required index.

Diff 25461

View Options

src/lib/elementary/efl_ui_select_model.c