Page MenuHomePhabricator

docs: Update Efl.Ui.Scrollbar docs
ClosedPublic

Authored by segfaultxavi on Fri, Sep 20, 4:33 AM.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
segfaultxavi created this revision.Fri, Sep 20, 4:33 AM
segfaultxavi requested review of this revision.Fri, Sep 20, 4:33 AM
zmike requested changes to this revision.Fri, Sep 20, 5:00 AM
zmike added inline comments.
src/lib/efl/interfaces/efl_ui_scrollbar.eo
35

My brain broke trying to read this. Send help. And better docs.

37

I think perhaps you meant and as a result the scrollbar is the size of the viewport and cannot be moved.

55–58

I forgot, is this affected by mirrored?

This revision now requires changes to proceed.Fri, Sep 20, 5:00 AM

Improving docs

segfaultxavi marked 2 inline comments as done.Fri, Sep 20, 6:13 AM
segfaultxavi added inline comments.
src/lib/efl/interfaces/efl_ui_scrollbar.eo
55–58

I really, really hope not. Otherwise, dragging the thumb to the left will move the viewport to the right... How can I check?

segfaultxavi added inline comments.Mon, Sep 23, 5:35 AM
src/lib/efl/interfaces/efl_ui_scrollbar.eo
55–58

I tried elm_test using the UI mirroring option and scrollbars behaved as normal. Don't know if it's related.

zmike requested changes to this revision.Mon, Sep 23, 1:51 PM
zmike added inline comments.
src/lib/efl/interfaces/efl_ui_scrollbar.eo
36

the scrollbar will have the same size as the scrollbar

...

...
...
what.

55–58

k

This revision now requires changes to proceed.Mon, Sep 23, 1:51 PM

Fix goddamned typo and updated event docs.

zmike accepted this revision.Tue, Sep 24, 11:24 AM
This revision is now accepted and ready to land.Tue, Sep 24, 11:24 AM
This revision was automatically updated to reflect the committed changes.