Page MenuHomePhabricator

efl_ui_win: default the window type to basic
ClosedPublic

Authored by bu5hm4n on Fri, Sep 20, 6:28 AM.

Details

Summary

normally when you create a window, you just want to have it beeing a
basic window. If not you still can set the window type.

ref T8229

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bu5hm4n created this revision.Fri, Sep 20, 6:28 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

bu5hm4n requested review of this revision.Fri, Sep 20, 6:28 AM
segfaultxavi accepted this revision.Fri, Sep 20, 7:00 AM
segfaultxavi added a subscriber: segfaultxavi.

I confirm this builds and passes tests, and C# examples do not need to provide the window type.

This revision is now accepted and ready to land.Fri, Sep 20, 7:00 AM
bu5hm4n updated this revision to Diff 25255.Fri, Sep 20, 7:14 AM

add test cases

segfaultxavi requested changes to this revision.Mon, Sep 23, 3:35 AM

nitpick: indentation is now wrong for all efl_add() calls where the efl_ui_win_type_set() has been removed.

This revision now requires changes to proceed.Mon, Sep 23, 3:35 AM
zmike accepted this revision.Mon, Sep 23, 5:57 AM
zmike added a subscriber: zmike.

Seems god

This revision was not accepted when it landed; it landed in state Needs Revision.Tue, Sep 24, 7:01 AM
Closed by commit rEFL594fc084427a: efl_ui_win: default the window type to basic (authored by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain Why
This revision was automatically updated to reflect the committed changes.