Page MenuHomePhabricator

test: add a new testcase for paging of scroller
Needs ReviewPublic

Authored by akanad on Mon, Sep 23, 10:08 PM.

Details

Reviewers
bu5hm4n
zmike
Summary

this patch added a new testcase for paging feature of elm_scroller.
A page number of a scroller gets changed while resizing the scroller.
T5151

Diff Detail

Repository
rEFL core/efl
Branch
arcpatch-D10105
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 13642
Build 9512: arc lint + arc unit
akanad created this revision.Mon, Sep 23, 10:08 PM
akanad requested review of this revision.Mon, Sep 23, 10:08 PM
zmike requested changes to this revision.Tue, Sep 24, 5:24 AM

This needs some small changes.

Also the test fails, which would break the build.

src/tests/elementary/elm_test_scroller.c
52

This is the wrong callback type; it should be (void *data, Evas *e, Evas_Object *obj, void *event_info). Also needs EINA_UNUSED to mark unused params.

68

Needs EINA_UNUSED to mark unused params.

75

int vs uint comparison: this generates a compiler warning.

83

Needs EINA_UNUSED to mark unused params.

138

This should be ecore_main_loop_iterate()

144

This should be ecore_main_loop_iterate()

150

This should be ecore_main_loop_iterate()

156

This should be ecore_main_loop_iterate()

This revision now requires changes to proceed.Tue, Sep 24, 5:24 AM
akanad updated this revision to Diff 25549.Tue, Sep 24, 9:19 PM
  • adding EINA_UNUSED marks
  • aligning a type of page_num variables

This testcase is what I described before at T5151.
there could be necessary more than 1 loop to complete what I intended.
ecore_main_loop_begin(get_me_to_those_events) seems required.
if I change it to ecore_main_loop_iterate(), test passes.

yes, this testcase is a failure case which I think to be fixed.
a patch is going to follow on T5151.