Page MenuHomePhabricator

efl_ui_win: default window type change should not be applied to legacy one
ClosedPublic

Authored by woohyun on Sep 24 2019, 10:18 PM.

Details

Summary

If my understanding is correct, below referenced commit needs to be applied to
efl_ui_win only.

@ref D10049

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
woohyun created this revision.Sep 24 2019, 10:18 PM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

woohyun requested review of this revision.Sep 24 2019, 10:18 PM
woohyun edited the summary of this revision. (Show Details)Sep 24 2019, 10:19 PM
woohyun added reviewers: bu5hm4n, zmike, segfaultxavi.
bu5hm4n accepted this revision.Sep 25 2019, 1:29 AM

Good catch.

This revision is now accepted and ready to land.Sep 25 2019, 1:29 AM
Closed by commit rEFL1c936631561a: efl_ui_win: default window type change should not be applied to legacy one (authored by woohyun, committed by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhySep 25 2019, 2:06 AM
This revision was automatically updated to reflect the committed changes.
zmike added a comment.Sep 25 2019, 3:44 AM

How was the unit test for this passing?