Page MenuHomePhabricator

c/cxx: Fix warning from clang -Weverything.
Needs ReviewPublic

Authored by brunobelo on Wed, Sep 25, 2:01 PM.

Details

Summary

some warning isn't gonna be fix like documentation-unknown-command,
reserved-id-macro, cast-qual, padded and others.
T8283

Test Plan

compile with clang and -Weverything, fixing the warnings.

Diff Detail

Repository
rEFL core/efl
Branch
arcpatch-D10172
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 13819
Build 9601: arc lint + arc unit
brunobelo created this revision.Wed, Sep 25, 2:01 PM
brunobelo requested review of this revision.Wed, Sep 25, 2:01 PM
lauromoura requested changes to this revision.Wed, Sep 25, 2:13 PM

A couple initial comments

src/bin/elementary/perf.c
154

count_get is deprecated, good.

src/lib/eina/eina_accessor.h
161 ↗(On Diff #25627)

Doesn't this break Eina ABI?

src/lib/eina/eina_iterator.h
167 ↗(On Diff #25627)

ABI...

This revision now requires changes to proceed.Wed, Sep 25, 2:13 PM
brunobelo edited the summary of this revision. (Show Details)Fri, Sep 27, 1:04 PM
brunobelo planned changes to this revision.Fri, Sep 27, 1:38 PM
brunobelo edited the summary of this revision. (Show Details)
brunobelo edited the summary of this revision. (Show Details)Fri, Sep 27, 3:27 PM
brunobelo updated this revision to Diff 25852.Tue, Oct 1, 3:25 PM

changing the abis breaks and change of cast-qual