Page MenuHomePhabricator
Differential D10174

elm: Fix potential leak in cv request add
ClosedPublic
Actions

Authored by lauromoura on Sep 25 2019, 3:42 PM.

Details

Reviewers
zmike
cedric
bu5hm4n
Commits
rEFL71694727a4c2: elm: Fix potential leak in cv request add
rEFL8686e14dc9bd: elm: Fix potential leak in cv request add
Summary

CID 1405809

Diff Detail

Repository
rEFL core/efl
Branch
arcpatch-D10174
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 13762
Build 9566: arc lint + arc unit
lauromoura created this revision.Sep 25 2019, 3:42 PM
lauromoura requested review of this revision.Sep 25 2019, 3:42 PM
lauromoura added inline comments.Sep 26 2019, 6:35 AM
src/lib/elementary/efl_ui_collection_view.c
1854

@bu5hm4n , shouldn't this #endif and label be after the if block below?

Just like the other methods that notify the manager.

cedric added inline comments.Sep 26 2019, 7:32 AM
src/lib/elementary/efl_ui_collection_view.c
1854

I agree, we can calculate the length before creating the request and avoid one allocation cycle for nothing completely.

lauromoura updated this revision to Diff 25704.Sep 26 2019, 8:45 AM

Updated by moving the variables and calculations used only in VIEWPORT_ENABLE actually inside the ifdef

cedric requested changes to this revision.Sep 26 2019, 4:00 PM

Ah no, this is incorrect. The idea is to refetch all the object after the deleted one. This patch seems to disable that completely.

This revision now requires changes to proceed.Sep 26 2019, 4:00 PM
lauromoura updated this revision to Diff 25757.Sep 27 2019, 7:19 AM

Update by only allocating the request if it will actually be used.

cedric requested changes to this revision.Oct 10 2019, 3:55 PM
cedric added inline comments.
src/lib/elementary/efl_ui_collection_view.c
1855

In efl we tend to declare variable at the top of the function.

1861

Couldn't this be request_length?

This revision now requires changes to proceed.Oct 10 2019, 3:55 PM
lauromoura updated this revision to Diff 26067.Oct 11 2019, 10:40 AM

Update after cedric's comments.

cedric accepted this revision.Oct 11 2019, 10:56 AM
This revision is now accepted and ready to land.Oct 11 2019, 10:56 AM
Closed by commit rEFL8686e14dc9bd: elm: Fix potential leak in cv request add (authored by lauromoura). · Explain WhyOct 13 2019, 7:43 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 25757

View Options

src/lib/elementary/efl_ui_collection_view.c

Loading...