Page MenuHomePhabricator

efl_core : stabilized Efl.Boolean_Model
Needs RevisionPublic

Authored by SanghyeonLee on Sep 26 2019, 4:49 AM.

Details

Summary

stabilized Efl.Boolean_Model

depends on D10189

Diff Detail

Repository
rEFL core/efl
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 13719
Build 9546: arc lint + arc unit
SanghyeonLee created this revision.Sep 26 2019, 4:49 AM
SanghyeonLee requested review of this revision.Sep 26 2019, 4:49 AM

DO NOT MERGE

build failed by boolean_iterator_get

is there any problem on iterator<ptr()>?
should we make this method @beta?

I do not think we need to stabilize this one for this release.

hmm... I think boolean model is quite useful to userside, but still user can access boolean data by property get right?
if then it seems not serious problem in here,
at least we still have a moment to out of beta for this class in tizen side, only few weeks though.

@cedric can we either move this here out of review queue or dicsuss what the plan of it is ?

@cedric can we either move this here out of review queue or dicsuss what the plan of it is ?

I think this is a useful model for user. It is pretty much feature complete at this point. I think we should do a review of its documentation and naming of things before we stabilize it. Hopefully nothing big.

@segfaultxavi could you share your opinion on this class.

This class should be deleted because the file has tabs instead of spaces.

segfaultxavi requested changes to this revision.Oct 29 2019, 7:01 AM
segfaultxavi added a subscriber: myoungwoon.

OK, the tabs have been fixed. @myoungwoon and I already worked on the documentation, so I think that part is OK.
The API is pretty simple, I see nothing wrong with it.

But something has to be done with that iterator<ptr(uint64)>, it does not build.

This revision now requires changes to proceed.Oct 29 2019, 7:01 AM