Page MenuHomePhabricator

evas_textblock: fix warning
AbandonedPublic

Authored by ali.alzyod on Sep 27 2019, 4:33 AM.

Details

Reviewers
bu5hm4n

Diff Detail

Repository
rEFL core/efl
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 13767
Build 9568: arc lint + arc unit
ali.alzyod created this revision.Sep 27 2019, 4:33 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

ali.alzyod requested review of this revision.Sep 27 2019, 4:33 AM
bu5hm4n requested changes to this revision.Sep 27 2019, 5:28 AM
  1. ot is still uninitialized when ti->text_props.len is 0.
  2. I would expect a bug if ot actaully is NULL, so i would put some EINA_SAFETY_ON_NULL_XXX macro after the two for loops. Which would also not require to check ot in the next few if's.
This revision now requires changes to proceed.Sep 27 2019, 5:28 AM

init with null

ali.alzyod added a comment.EditedSep 27 2019, 10:42 AM

I would expect a bug if ot actaully is NULL, so i would put some EINA_SAFETY_ON_NULL_XXX macro after the two for loops. Which would also not require to check ot in the next few if's.

This will never happen, this patch just to fix compilation warning you have, By the way I will check why I didn't have this warning

ali.alzyod abandoned this revision.Tue, Oct 29, 1:04 AM