Page MenuHomePhabricator

c/c++: Removing low priorities warnings.
Needs RevisionPublic

Authored by brunobelo on Oct 1 2019, 6:47 AM.

Details

Summary

a lot of warnings cast-like.

Diff Detail

Repository
rEFL core/efl
Branch
warnings_clang
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 13817
Build 9600: arc lint + arc unit
brunobelo created this revision.Oct 1 2019, 6:47 AM
brunobelo requested review of this revision.Oct 1 2019, 6:47 AM
bu5hm4n added inline comments.
src/lib/eina/eina_array.c
223

I do not know why this would be needed ?
(Same for the other function prototypes)

vtorri added a subscriber: vtorri.Nov 5 2019, 8:31 PM
vtorri added inline comments.
src/lib/eina/eina_counter.c
104

use uintptr_t instead of unsigned long (on windows 64 bits, long is a 4 bytes type), or size_t

cedric requested changes to this revision.Jan 1 2020, 2:16 PM
cedric added inline comments.
src/lib/eina/eina_binbuf_template_c.x
22

Why are this in the .x? This means new symbol being exported (With no EAPI).

src/lib/eina/eina_inline_value_util.x
153

I tend to want to keep this as some code editor are not happy if they do not see ;.

This revision now requires changes to proceed.Jan 1 2020, 2:16 PM
brunobelo added inline comments.Jan 2 2020, 11:48 AM
src/lib/eina/eina_inline_value_util.x
153

EINA_VALUE_NEW is a macro to a function, so, this is something like

void foo() 
{
 // code
};

that's why the compiler complains.