Page MenuHomePhabricator

docs: enable compression for tar file and avoid file name clash
ClosedPublic

Authored by stefan_schmidt on Oct 1 2019, 8:19 AM.

Details

Summary

While the target name implies a compression we only ever put this all
into a tar archive so far. Using xz compression as we do with our source
archives.
Also adjust the file naming to avoid clashing with the source tarballs.
We used -doc with autotools before, so this is really more of a catchup.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
stefan_schmidt created this revision.Oct 1 2019, 8:19 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

stefan_schmidt requested review of this revision.Oct 1 2019, 8:19 AM

The name change makes perfect sense, but I do not see where compression is being enabled (I am no tar expert).

ProhtMeyhet added a subscriber: ProhtMeyhet.EditedOct 1 2019, 3:30 PM

The name change makes perfect sense, but I do not see where compression is being enabled (I am no tar expert).

It's running a bash command, here tar, and tar determines from the filename what compression to use, but i agree in automatic build scripts you should use the long names, or all the options instead of magic. the option, thankfully, is just --xz :-)

be explicit on compress options

As @ProhtMeyhet explained tar determines the compression from the filename suffix I added. Maybe it was a bit lazy doing it without the tar option, its just how I use it all the time on the commandline. Let me fix this.

segfaultxavi accepted this revision.Oct 2 2019, 1:38 AM

Works as advertised, I see nothing wrong with this.

This revision is now accepted and ready to land.Oct 2 2019, 1:38 AM
This revision was automatically updated to reflect the committed changes.