Page MenuHomePhabricator

efl_app and efl_exe: support get and set priority of a process on Windows
Needs RevisionPublic

Authored by vtorri on Oct 5 2019, 5:25 AM.

Details

Test Plan

compilation on Windows

Diff Detail

Repository
rEFL core/efl
Branch
vtorri_priority
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 13853
Build 9619: arc lint + arc unit
vtorri created this revision.Oct 5 2019, 5:25 AM
vtorri requested review of this revision.Oct 5 2019, 5:25 AM
raster requested changes to this revision.Oct 8 2019, 6:17 AM

see inline comments

src/lib/ecore/efl_app.c
53

why not just use primap[] since you declare the content below?

82

good catch :)

105

can we make the above super call shared? so hav the #else/#endif around the above getpriority (or the below linux version)

so basically above a #ifdef _WIN32 ... #else ... #endif then return .... super...; so the if (!p) or if (errno != 0) is the last line in the #ifdef before the return that's outside (and shared).

107

why don't you use primap to map this like the linux code - just walk the primap array and map it to the right efl one... :) in fact a quick think... the same for loop for primap walking should work for both windows and linux... so no need to duplicate and have this for loop be shared

This revision now requires changes to proceed.Oct 8 2019, 6:17 AM
vtorri added inline comments.Tue, Sep 15, 6:52 AM
src/lib/ecore/efl_app.c
53

because of line 89 below (SetPriorityClass() call)

105

possible to do of course, but just for 1 line...

107

the values returned by GetPriorityClass() are completely different