Page MenuHomePhabricator

evas/language: #ifdef guard variable which is only used inside #ifdef
ClosedPublic

Authored by zmike on Wed, Oct 9, 10:24 AM.

Details

Summary

this variable is already only changed inside an #ifdef, so declare and
free it only inside the same ifdef for clarity

CIDs 1401016, 1400807

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zmike created this revision.Wed, Oct 9, 10:24 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

zmike requested review of this revision.Wed, Oct 9, 10:24 AM

Does that one have a travis build ?

zmike added a comment.Wed, Oct 9, 10:57 AM

Er what? Why would this need a travis build when there's only 4 cases where the variable is referenced in the function?

different build options might result in different #defines, which might discover some oversight.

cedric accepted this revision.Thu, Oct 10, 3:51 PM
This revision is now accepted and ready to land.Thu, Oct 10, 3:51 PM
This revision was automatically updated to reflect the committed changes.