Page MenuHomePhabricator

csharp: Add missing docs to slice.
ClosedPublic

Authored by lauromoura on Wed, Oct 9, 3:24 PM.

Details

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
lauromoura created this revision.Wed, Oct 9, 3:24 PM
lauromoura requested review of this revision.Wed, Oct 9, 3:24 PM
segfaultxavi requested changes to this revision.Thu, Oct 10, 1:39 AM
segfaultxavi added inline comments.
src/bindings/mono/eina_mono/eina_slice.cs
11

interface

17

Units?

29

What? Len and Length? At the very least you gotta explain me this.

40

If this inherits from ISliceBase why is it defining Len, Mem and Length again?

82

Same as above.

This revision now requires changes to proceed.Thu, Oct 10, 1:39 AM
lauromoura added inline comments.Thu, Oct 10, 4:27 PM
src/bindings/mono/eina_mono/eina_slice.cs
40

These are the actual definitions of the properties declared in the interface.

82

Ditto.

lauromoura updated this revision to Diff 26043.Thu, Oct 10, 4:28 PM

Some updates to the docs.

lauromoura added inline comments.Thu, Oct 10, 4:31 PM
src/bindings/mono/eina_mono/eina_slice.cs
29

Yeah. These two are quite confunsing and maybe are some implementation detail that leaked from when merged in the binding in the first version. Should we create a new task to clean it up?

segfaultxavi accepted this revision.Fri, Oct 11, 2:23 AM
segfaultxavi added inline comments.
src/bindings/mono/eina_mono/eina_slice.cs
29

OK, please create a task so we don't forget that this requires an explanation.

40

Argh, sorry, this is a struct, ISliceBase is an interface. My bad.

This revision is now accepted and ready to land.Fri, Oct 11, 2:23 AM
This revision was automatically updated to reflect the committed changes.