Differential D10339

mono: encapsulate internal delegates
ClosedPublic
Actions

Authored by lauromoura on Oct 10 2019, 4:07 AM.

Tags

Subscribers

cedric, reviewers, committers, woohyun

Details

Reviewers

Jaehyun_Cho
YOhoho
brunobelo
segfaultxavi

Commits

rEFL46ebd2033b22: mono: encapsulate internal delegates
rEFLfca71d4275fc: mono: encapsulate internal delegates

Summary

Depends on D10337

Test Plan

meson setup -Dbindings=mono,cxx -Dmono-beta=true

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

YOhoho created this revision.Oct 10 2019, 4:07 AM

Herald added a project: efl. · View Herald TranscriptOct 10 2019, 4:07 AM

Herald added subscribers: committers, reviewers, cedric. · View Herald Transcript

YOhoho requested review of this revision.Oct 10 2019, 4:07 AM

Harbormaster completed remote builds in B13922: Diff 26012.Oct 10 2019, 4:07 AM

YOhoho added a child revision: D10345: mono: encapsulate internal iwrapper members.Oct 10 2019, 4:35 AM

YOhoho mentioned this in D10337: mono: introduce friend assembly.Oct 10 2019, 9:45 PM

Currently the test library Dummy.Part_Holder implements Efl.Part.part_get and currently needs access to its delegate in the generated code.

Hooray for hiding internal stuff!
But I cannot apply this.

This revision now requires changes to proceed.Oct 24 2019, 9:39 AM

Accepting after rebase

Well, updating after rebasing, as Xavi started reviewing.

Update after rebase.

Harbormaster completed remote builds in B14230: Diff 26450.Oct 28 2019, 3:16 PM

No serious review here, just checking that it built :)

YOhoho accepted this revision.Oct 29 2019, 7:17 AM

This revision is now accepted and ready to land.Oct 29 2019, 7:17 AM

Ooops. Didn't refresh the page before adding Bruno :)

Closed by commit rEFL46ebd2033b22: mono: encapsulate internal delegates (authored by lauromoura). · Explain WhyOct 29 2019, 8:24 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/bin/eolian_mono/eolian/mono/function_definition.hh (4 lines)
M			src/bin/eolian_mono/eolian/mono/function_pointer.hh (2 lines)

Diff 26506

src/bin/eolian_mono/eolian/mono/function_definition.hh

Loading...

src/bin/eolian_mono/eolian/mono/function_pointer.hh

Loading...