Details
- Reviewers
Jaehyun_Cho zmike segfaultxavi - Maniphest Tasks
- T8288: Animation API
- Commits
- rEFLf47b9277453e: efl_canvas_animation_rotate: adjust API
Diff Detail
- Repository
- rEFL core/efl
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
I like this addition. I just prefer when API being added to Eina are done in two step, one patch for eina and another one rolling it in everywhere. For the current case, it is just a one line, so I won't oppose this patch landing, but I just wanted to let you know my preference for future reference.
src/lib/eina/eina_vector.h | ||
---|---|---|
35 | Is our preferred doc cop @segfaultxavi happy here? |
src/lib/eina/eina_vector.h | ||
---|---|---|
35 | NO, obviously. But I was unsure on how we document macros so I let it slip :) |
src/lib/eina/eina_vector.h | ||
---|---|---|
35 | None of these macros is documented in eina. I do not want to start a discussion here on how to document them. Futher more, its a Vector 2 with 2 fields, what would you think this is doing ? brewing some coffee ? :P |
src/lib/eina/eina_vector.h | ||
---|---|---|
35 | Hrmpffff mumble mumble mumble I am not happy but yeah, OK. But at some point ALL public-facing API (macros included) will have to be documented. |