Page MenuHomePhabricator

csharp: Avoid direct usage of some dllimport funcs
ClosedPublic

Authored by lauromoura on Oct 10 2019, 3:47 PM.

Details

Summary

Instead of accessing them directly, generated code should access them
only through proper managed wrappers.

JIT should take care of inline them.

This would allow D10338 without depending on the friendly assembly feature.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
lauromoura created this revision.Oct 10 2019, 3:47 PM
lauromoura requested review of this revision.Oct 10 2019, 3:47 PM

I think c# method name should begin with verb.
EventCallbackCall -> CallEventCallback
ClassGet -> GetClass

lauromoura updated this revision to Diff 26135.Oct 14 2019, 2:46 PM

Update after @YOhoho's comments.

YOhoho accepted this revision.Oct 14 2019, 7:17 PM

Thank you.

This revision is now accepted and ready to land.Oct 14 2019, 7:17 PM
This revision was automatically updated to reflect the committed changes.