Page MenuHomePhabricator

efl_ui: remove some legacy types from eo
AbandonedPublic

Authored by zmike on Oct 14 2019, 6:28 AM.

Details

Summary

these were copied from legacy but serve no purpose since they aren't being used

ref T8372

Diff Detail

Repository
rEFL core/efl
Branch
master
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 13986
zmike created this revision.Oct 14 2019, 6:28 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

zmike requested review of this revision.Oct 14 2019, 6:28 AM

Tested locally and worked fine. As it was discussed on IRC, there is the issue of removing Focus_Autoscroll_Mode, which was had its @beta removed this release.

cedric requested changes to this revision.Thu, Oct 24, 2:48 PM

Tested locally and worked fine. As it was discussed on IRC, there is the issue of removing Focus_Autoscroll_Mode, which was had its @beta removed this release.

I don't think we can remove that one.

This revision now requires changes to proceed.Thu, Oct 24, 2:48 PM
zmike added a comment.Fri, Oct 25, 6:41 AM

Because we plan to use it or because it's "stable"?

zmike requested review of this revision.Fri, Oct 25, 6:41 AM

Because it has been marked stable.

Mhm, right now we do not use focus_autoscroll_mode. But I think there will be a point in future where we want to have that ? Can we just keep it as @beta ? (Its just not used right now, but i see potential use in future, we just have to define it properly)

bu5hm4n requested changes to this revision.Mon, Oct 28, 12:20 AM
This revision now requires changes to proceed.Mon, Oct 28, 12:20 AM
zmike abandoned this revision.Mon, Oct 28, 5:29 AM