Page MenuHomePhabricator

csharp: Raise exceptions on property accessors failures
Changes PlannedPublic

Authored by felipealmeida on Oct 14 2019, 8:36 PM.

Details

Summary

Only for bools and eina_errors.

For other types, the return value are discarded.

Test Plan

see attached tests

Diff Detail

Repository
rEFL core/efl
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 14008
Build 9725: arc lint + arc unit
lauromoura created this revision.Oct 14 2019, 8:36 PM
lauromoura requested review of this revision.Oct 14 2019, 8:36 PM

This will throw an exception even if the returned bool was not meant to indicate error.
Let's wait for the outcome of the mailing list discussion on this topic:
https://sourceforge.net/p/enlightenment/mailman/message/36789680/

lauromoura planned changes to this revision.Dec 17 2019, 5:49 AM

Changes needed after T8383 is done adding the Eina.Success_Flag typedef to indicate a bool should be checked for.

felipealmeida commandeered this revision.Dec 21 2019, 1:58 PM
felipealmeida edited reviewers, added: lauromoura; removed: felipealmeida.