Page MenuHomePhabricator

Fix : Check that the file has a protocol.
Needs ReviewPublic

Authored by thierry1970 on Oct 15 2019, 8:02 AM.

Details

Reviewers
devilhorns

Diff Detail

Repository
rE core/enlightenment
Branch
Efreet_Command
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 14023
Build 9735: arc lint + arc unit
thierry1970 created this revision.Oct 15 2019, 8:02 AM
thierry1970 requested review of this revision.Oct 15 2019, 8:02 AM
thierry1970 added a comment.EditedOct 15 2019, 8:21 AM

enlightenment_open is broken.
The check of the file to decide if it is distant can fail, whereas in the path of the file there is ":"
Example:

/run/user/1000/gvfs/mtp:host=Xiaomi_MI_9_e225d943/Shared Internal Storage Space/DCIM/Camera/IMG_20191007_142922.jpg

This commit is associated : D10409.

raster added a subscriber: raster.Oct 15 2019, 9:07 AM
raster added inline comments.
src/bin/e_open.c
483

shouldn't that be && *p && ? :)

thierry1970 updated this revision to Diff 26162.EditedOct 15 2019, 9:36 AM

Corrected :)