Page MenuHomePhabricator

Efl.Canvas.Group: implement Efl.Gfx.Filter
Needs ReviewPublic

Authored by kimcinoo on Oct 16 2019, 11:34 PM.

Details

Reviewers
Hermet
jsuya
zmike
Summary

This patch makes Efl.Canvas.Group work for Efl.Gfx.Filter

Diff Detail

Repository
rEFL core/efl
Branch
Efl.Canvas.Group_implement_Efl.Canvas.Filter.Internal
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 14456
Build 9950: arc lint + arc unit
kimcinoo created this revision.Oct 16 2019, 11:34 PM
kimcinoo requested review of this revision.Oct 16 2019, 11:34 PM
kimcinoo updated this revision to Diff 26199.Oct 16 2019, 11:38 PM

Implement what Efl.Canvas.Goup needs only

kimcinoo updated this revision to Diff 26200.Oct 16 2019, 11:49 PM

Remove unnecessary change

zmike requested changes to this revision.Oct 17 2019, 7:09 AM
zmike added a subscriber: zmike.
zmike added inline comments.
src/lib/evas/canvas/evas_object_smart.c
961

This function should use the unified API everywhere and not legacy + unified.

This revision now requires changes to proceed.Oct 17 2019, 7:09 AM
kimcinoo updated this revision to Diff 26221.Oct 17 2019, 8:09 PM

Use the unified API everywhere and not legacy + unified

kimcinoo marked an inline comment as done.Oct 17 2019, 8:10 PM
zmike added a comment.Oct 18 2019, 6:44 AM

This seems like a pretty reasonable patch, will wait on @cedric for a second review.

src/lib/evas/canvas/evas_object_smart.c
961

I think also you should probably be setting all the properties here inside the constructor for performance? cc @cedric

Hermet requested changes to this revision.Oct 31 2019, 3:50 PM

Some comments

src/lib/evas/canvas/evas_object_smart.c
955

Don't we reuse the filter object here?

973

Question: How to sync stacking/visibility changes after this construction?

This revision now requires changes to proceed.Oct 31 2019, 3:50 PM
kimcinoo updated this revision to Diff 26812.Nov 11 2019, 4:41 PM
kimcinoo marked 3 inline comments as done.

Following comments

kimcinoo added inline comments.Nov 11 2019, 4:41 PM
src/lib/evas/canvas/evas_object_smart.c
973

I need a hint how to sync stacking.