Page MenuHomePhabricator

Elm_Widget: Del pre hook should be able to return bool value
Needs RevisionPublic

Authored by godlytalias on Oct 17 2019, 6:49 AM.

Details

Summary

In certain scenarios, widgets like genlist may have to perform
VI effects during deletion of items, in those case, genlist want to
get del pre hook before item deletion starts and may want to defer deletion
till deletion animation ends

Signed-off-by: Godly T.Alias <godly.talias@samsung.com>

Test Plan

elm_object_item_del of any elm widget items

Diff Detail

Repository
rEFL core/efl
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 14056
Build 9762: arc lint + arc unit
godlytalias created this revision.Oct 17 2019, 6:49 AM
godlytalias requested review of this revision.Oct 17 2019, 6:49 AM
zmike requested changes to this revision.Oct 17 2019, 7:39 AM
zmike added a subscriber: zmike.

This causes elm unit tests to fail.

This revision now requires changes to proceed.Oct 17 2019, 7:39 AM

@zmike please let me know which elm unit test is failing and on how to execute and test

zmike added a comment.Oct 18 2019, 6:21 AM

Copied from our chat for posterity:

If you run meson test after the build, you'll see that the elementary-suite fails with this patch applied
you can debug this with something like EFL_RUN_IN_TREE=1 CK_FORK=no gdb src/tests/elementary/elementary_suite
setting breakpoints normally
the _ck_assert_failed function can be used as a breakpoint at any time as the point where the test failure occurs