Page MenuHomePhabricator

elm/code: check save file attrs after opening
ClosedPublic

Authored by zmike on Oct 17 2019, 7:40 AM.

Details

Summary

ensure that they haven't changed between time of check and time of open

CID 1396966

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zmike created this revision.Oct 17 2019, 7:40 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

zmike requested review of this revision.Oct 17 2019, 7:40 AM
ProhtMeyhet added a subscriber: ProhtMeyhet.

sorry, but this does not guarantee you anything. there are so many interrupts possible between these calls, anything below a lock. or an atomic call, will be useless.

cedric accepted this revision.Oct 24 2019, 2:45 PM

sorry, but this does not guarantee you anything. there are so many interrupts possible between these calls, anything below a lock. or an atomic call, will be useless.

This is an operation on a file. Lock and atomic do not have any possible use in this context. Calling fstat on fileno guarantee that it return the valid information for this fd.

This revision is now accepted and ready to land.Oct 24 2019, 2:45 PM
This revision was automatically updated to reflect the committed changes.