Page MenuHomePhabricator

csharp: Refactor MarshalOwn
ClosedPublic

Authored by lauromoura on Oct 18 2019, 3:00 PM.

Details

Summary

Instead of using the empty interface as tag, split MarshalOwn into two
marshalers that can be used directly.

Fixes T8395 (CA1040)

Test Plan

no new functionality. Use existing tests

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
lauromoura created this revision.Oct 18 2019, 3:00 PM
lauromoura requested review of this revision.Oct 18 2019, 3:00 PM

This patch also will fix T8389(CA1000)

src/bindings/mono/eo_mono/iwrapper.cs
1111

Please remove comment.

1166–1167

Eina.Log.Debug("MarshalEoMove.MarshallManagedToNative");

1191

Please remove comment.

lauromoura updated this revision to Diff 26569.Oct 30 2019, 1:06 PM

Update after comments.

While hiding things in D10344 resolved the warning as CA1040 is focused on public interface by default, this patch is still useful as avoids runtime usage of typeof and makes the intent of the marshallers more explicit.

lauromoura marked 3 inline comments as done.Oct 30 2019, 1:15 PM
YOhoho accepted this revision.Oct 30 2019, 8:06 PM
This revision is now accepted and ready to land.Oct 30 2019, 8:06 PM
This revision was automatically updated to reflect the committed changes.