Differential D10458

csharp: Add comparables operators to eina_value.
ClosedPublic
Actions

Authored by brunobelo on Oct 18 2019, 4:42 PM.

Tags

Subscribers

bu5hm4n, cedric, reviewers, committers

Details

Reviewers

lauromoura
felipealmeida
segfaultxavi
YOhoho
bu5hm4n

Maniphest Tasks

T8394: C#: CA1036: Override methods on comparable types

Commits

rEFL19588be0b996: csharp: Add comparables operators to eina_value.

Summary

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

brunobelo created this revision.Oct 18 2019, 4:42 PM

Herald added a project: efl. · View Herald TranscriptOct 18 2019, 4:42 PM

Herald added subscribers: committers, reviewers, cedric. · View Herald Transcript

brunobelo requested review of this revision.Oct 18 2019, 4:42 PM

Harbormaster completed remote builds in B14078: Diff 26253.Oct 18 2019, 4:42 PM

Test

This revision now requires changes to proceed.Oct 23 2019, 10:18 PM

Seems to work :)

YOhoho requested changes to this revision.Oct 24 2019, 12:49 AM

YOhoho added inline comments.

src/bindings/mono/eina_mono/eina_value.cs
2928	Is this method necessary? `Value` class does not implement `IComparable` interface.
2940	"Eina.Value />. --> "Eina.Value" />. It will fix compiler error. ../src/bindings/mono/eina_mono/eina_value.cs(3003,16): error CS1570: Warning as Error: XML documentation comment on `Eina.Value.CompareTo(Eina.Value)' is not well-formed XML markup ('<', hexadecimal value 0x3C, is an invalid attribute character. Line 2, position 2.)
2946	I'm not sure that `static Compare` method is needed. You can use `CompareTo` in operator-overloading. check the comment below.
3021	You can use `CompareTo` for example, `lhs.CompareTo(rhs) < 0;`

brunobelo added inline comments.Oct 24 2019, 3:15 PM

src/bindings/mono/eina_mono/eina_value.cs
2928	on line 1079, Value implements IComparable.
2940	yeah, dotnet build was supressing doc errors.
2946	Just following microsoft example https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1036?view=vs-2019
3021	If remove `Compare` is not needed , it provides early stop for `lhs == rhs` and `ref(lhs) == null`. I tried to use microsoft example by standard.

fixing doc.

Harbormaster completed remote builds in B14168: Diff 26363.Oct 24 2019, 3:42 PM

brunobelo added inline comments.Oct 24 2019, 4:24 PM

src/bindings/mono/eina_mono/eina_value.cs
3021	with `lhs == null`, `lhs < rhs` should work, but using `lhs.CompareTo(rhs) < 0` raise `NullReferenceException`

YOhoho added inline comments.Oct 24 2019, 7:08 PM

src/bindings/mono/eina_mono/eina_value.cs
2928	That is `IComparable<T>`. public interface IComparable<in T> { int CompareTo(T other); }
2946	Ah, Ignore my comment.
3021	Ah, Ignore my comment.

updating

Harbormaster completed remote builds in B14175: Diff 26370.Oct 25 2019, 6:08 AM

YOhoho accepted this revision.Oct 27 2019, 3:35 PM

This revision is now accepted and ready to land.Oct 27 2019, 3:35 PM

Closed by commit rEFL19588be0b996: csharp: Add comparables operators to eina_value. (authored by brunobelo, committed by lauromoura). · Explain WhyOct 28 2019, 4:43 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/bindings/mono/eina_mono/eina_value.cs (126 lines)
M			src/tests/efl_mono/Value.cs (11 lines)

Diff 26460

src/bindings/mono/eina_mono/eina_value.cs

Loading...

src/tests/efl_mono/Value.cs

Loading...