ref T8394
Details
Diff Detail
- Repository
- rEFL core/efl
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
src/bindings/mono/eina_mono/eina_value.cs | ||
---|---|---|
2928 | Is this method necessary? | |
2940 | "Eina.Value />. --> "Eina.Value" />. It will fix compiler error. ../src/bindings/mono/eina_mono/eina_value.cs(3003,16): error CS1570: Warning as Error: XML documentation comment on `Eina.Value.CompareTo(Eina.Value)' is not well-formed XML markup ('<', hexadecimal value 0x3C, is an invalid attribute character. Line 2, position 2.) | |
2946 | I'm not sure that static Compare method is needed. You can use CompareTo in operator-overloading. check the comment below. | |
3021 | You can use CompareTo |
src/bindings/mono/eina_mono/eina_value.cs | ||
---|---|---|
2928 | on line 1079, Value implements IComparable. | |
2940 | yeah, dotnet build was supressing doc errors. | |
2946 | Just following microsoft example | |
3021 | If remove Compare is not needed , it provides early stop for lhs == rhs and ref(lhs) == null. |
src/bindings/mono/eina_mono/eina_value.cs | ||
---|---|---|
3021 | with lhs == null, lhs < rhs should work, but using lhs.CompareTo(rhs) < 0 raise NullReferenceException |