Page MenuHomePhabricator

Efl.Gfx.Frame_Controller: Add sector property
ClosedPublic

Authored by jsuya on Thu, Oct 24, 11:58 PM.

Details

Summary

These APIs to get and set frames for a specific section for playing section.

Depends on D10505

Test Plan

N/A

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
jsuya created this revision.Thu, Oct 24, 11:58 PM
jsuya requested review of this revision.Thu, Oct 24, 11:58 PM
Hermet requested changes to this revision.Fri, Oct 25, 3:35 AM

Please check a comment.

src/lib/efl/interfaces/efl_gfx_frame_controller.eo
101

I think we can define interface like this in the frame_controller pov.

Eina_Bool efl_gfx_frame_controller_sector_set(frame_controller, "sector_name", int begin, int end);
Eina_Bool efl_gfx_frame_controller_sector_get(frame_controller, "sector_name", &begin, &end);

This revision now requires changes to proceed.Fri, Oct 25, 3:35 AM
jsuya updated this revision to Diff 26655.Sun, Nov 3, 6:23 PM

Update patch
-Change property name

jsuya marked an inline comment as done.Sun, Nov 3, 6:24 PM
jsuya updated this revision to Diff 26656.Sun, Nov 3, 6:26 PM
jsuya retitled this revision from Efl.Gfx.Frame_Controller: Add sector_frame_get method to Efl.Gfx.Frame_Controller: Add sector_get property.

update commit message

Hermet accepted this revision.Mon, Nov 4, 7:56 AM
This revision is now accepted and ready to land.Mon, Nov 4, 7:56 AM
Hermet requested changes to this revision.Mon, Nov 4, 8:06 AM

This interface will be worthy when player supports this sector playing,

*sector_set("alias", 0.0, 0.1);
*play("alias");

It would be better if you fill up more details(example) in the doc how to make it functional, specifically how this sector can be used for in user level. with such a usecase:

This revision now requires changes to proceed.Mon, Nov 4, 8:06 AM
jsuya updated this revision to Diff 26703.Wed, Nov 6, 1:41 AM

update patch

  • add sector_set
jsuya updated this revision to Diff 26704.Wed, Nov 6, 1:41 AM
jsuya retitled this revision from Efl.Gfx.Frame_Controller: Add sector_get property to Efl.Gfx.Frame_Controller: Add sector property.
jsuya edited the summary of this revision. (Show Details)

update commie message

jsuya updated this revision to Diff 26705.Wed, Nov 6, 1:50 AM
jsuya edited the summary of this revision. (Show Details)

update message

Hermet accepted this revision.Mon, Nov 11, 4:10 PM
This revision is now accepted and ready to land.Mon, Nov 11, 4:10 PM
This revision was automatically updated to reflect the committed changes.