Page MenuHomePhabricator

elm/genlist: fix item highlight/unhighlight eventing on clicks
ClosedPublic

Authored by zmike on Oct 25 2019, 7:21 AM.

Details

Summary
  • highlight should only be triggered on mouse down, as that is the point of interaction with an item which indicates it is "in use"; a mouse-up event cannot occur on an item which has not previously received a mouse-down event, so toggling this on mouse-up will be wrong/duplicated 100% of the time
  • unhighlight should only be triggered during mouse-up events if the list is in no-select mode, as it will otherwise be implicitly during selection if necessary

this should ensure that these events are emitted exactly one time and correctly
for each click event
Depends on D10516

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zmike created this revision.Oct 25 2019, 7:21 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

zmike requested review of this revision.Oct 25 2019, 7:21 AM
cedric accepted this revision.Oct 25 2019, 10:55 AM
This revision is now accepted and ready to land.Oct 25 2019, 10:55 AM
Closed by commit rEFL7a6d5dd9f331: elm/genlist: fix item highlight/unhighlight eventing on clicks (authored by zmike, committed by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyOct 29 2019, 8:12 AM
This revision was automatically updated to reflect the committed changes.