Page MenuHomePhabricator

elm/genlist: only add calc job on theme apply if already finalized
ClosedPublic

Authored by zmike on Oct 25 2019, 7:21 AM.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zmike created this revision.Oct 25 2019, 7:21 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

cedric accepted this revision.Oct 25 2019, 10:57 AM
This revision is now accepted and ready to land.Oct 25 2019, 10:57 AM

@cedric you accept it so fast.
I tested all the patches in dev/zmike/genlist and confirmed it works very well in desktop test cases.
most of code that removed for optimization is exist for some issue cases,
but as time passed and all core frameworks are updated,
it would be great opportunity to confirm we really need this code or not.
but for Tizen,
I'm little bit afraid of applying this patch as their are so many un-expected usage and issues which wasn't really considered as issue on desktop environment.
thankfully we are only using upstream genlist in one profile which doesn't have that much usage, so I can find out issue more easily so it can be doable thing.

thanks for the great contribution for this :)

Closed by commit rEFLdf79f01b2a9f: elm/genlist: only add calc job on theme apply if already finalized (authored by zmike, committed by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyOct 29 2019, 8:13 AM
This revision was automatically updated to reflect the committed changes.