elm/genlist: redo focus adapter management on item blocks
AbandonedPublic
Actions

Authored by zmike on Oct 25 2019, 7:21 AM.

Details

Reviewers

Summary

creating these based on item block realize state is a good idea, but
genlist items can be realized even if their item block is not realized
and so this ends up failing in that case
Depends on D10519

Diff Detail

Repository

rEFL core/efl

Branch

master

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 14188

zmike created this revision.Oct 25 2019, 7:21 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

zmike requested review of this revision.Oct 25 2019, 7:21 AM

zmike added a child revision: D10521: elm/genlist: freeze/thaw canvas when processing item queue.

Harbormaster completed remote builds in B14188: Diff 26386.Oct 25 2019, 7:28 AM

cedric added a reviewer: bu5hm4n.Oct 25 2019, 10:20 AM

Can you elaborate on when the item can be realized without the block beeing realized ? because that means that _item_block_realize isn`t called in the group_calculate
*or* the item is not within the visual boundaries of its block, which means that i would rather prefer *anther* adapter added for that case.

My main concern here is that the registering in the item realization is again expansive, since you need to set the order of items to the block, which could be a rather big list, where not a lot of items are registered.

src/lib/elementary/elm_genlist.c
1847	You need to re-set the order of children again to the EO_OBJ(it) otherwise tab movement will be in the order of elements beeing realized, instead of the linear order it has on the screen.

This revision now requires changes to proceed.Oct 27 2019, 7:41 AM

In D10520#196167, @bu5hm4n wrote:

Can you elaborate on when the item can be realized without the block beeing realized ? because that means that _item_block_realize isn`t called in the group_calculate
*or* the item is not within the visual boundaries of its block, which means that i would rather prefer *anther* adapter added for that case.

My main concern here is that the registering in the item realization is again expansive, since you need to set the order of items to the block, which could be a rather big list, where not a lot of items are registered.

There's a number of cases in _item_block_recalc where an item may be realized solely for calculations even though the block is not yet realized. These cases are triggered by the tests in D10528.

src/lib/elementary/elm_genlist.c
1847	I don't know what this means?

zmike abandoned this revision.Oct 28 2019, 12:52 PM

Revision Contents
Changeset List

			Path	Packages
~			src/lib/elementary/elm_genlist.c (57 lines)

Commit	Tree	Parents	Author	Summary	Date
a1f831dab0f9	c2ef90842f4e	a3ba7201f4d5	Mike Blumenkrantz	(Show More…)	Oct 21 2019, 12:59 PM

Status	Author	Revision
Closed	zmike	D10531 tests/loop_timer: add port of ecore_timer behavior tests for loop_timer
Closed	zmike	D10547 tests/ecore: add intensive test for recursive timer usage
Closed	zmike	D10530 tests/ecore: make timer behavior test even more strict
Closed	zmike	D10528 tests/genlist: add behavior testing for nearly all genlist events
Closed	zmike	D10544 elm/genlist: fix item focus unregister on item move
Closed	zmike	D10543 elm/genlist: hide cached item contents and mark content unfocusable during calc
Closed	zmike	D10533 elm/genlist: set pan need recalc during item move on item position change
Closed	zmike	D10527 elm/genlist: fix "drag" smart callback
Closed	zmike	D10526 elm/genlist: trigger filter,done callback immediately if no filter queue exists
Closed	zmike	D10525 elm/genlist: slightly simplify use of _item_filtered_get()
Closed	zmike	D10524 elm/genlist: defer recalc when applying a name filter
Closed	zmike	D10523 elm/genlist: remove calc jobs
Closed	zmike	D10522 elm/genlist: don't process entire item queue on each item add
Closed	zmike	D10521 elm/genlist: freeze/thaw canvas when processing item queue
Abandoned	zmike	D10520 elm/genlist: redo focus adapter management on item blocks
Closed	zmike	D10519 elm/genlist: only add calc job on theme apply if already finalized
Closed	zmike	D10518 elm/genlist: remove misleading "changed" signal
Closed	zmike	D10517 elm/genlist: fix item highlight/unhighlight eventing on clicks
Closed	zmike	D10516 tests/ecore: add more grueling timer throughput test
Closed	zmike	D10546 tests/ecore: do not create global test timeout timer if running unforked
Closed	zmike	D10545 ecore/timer: correctly handle recursive deletion of legacy timers
Closed	zmike	D10515 efl/timer: correctly handle recursion for timer processing
Closed	zmike	D10514 efl/timer: don't attempt instantiating timers until they're finalized
Closed	zmike	D10513 tests/genlist: fix tree test sizing
Closed	zmike	D10512 tests/elm: add utility function to trigger a mouse drag
Closed	zmike	D10511 tests/elm: make argv a static char so it never goes out of scope and crashes
Closed	zmike	D10510 tests/elm: add util functions for clicking objects/parts with event flags
Closed	zmike	D10509 tests/elm: add util callback for incrementing an int data

Diff 26386

View Options

src/lib/elementary/elm_genlist.c

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	26386	a3ba720		Oct 25 2019, 7:21 AM	★	★