Page MenuHomePhabricator

elm/genlist: don't process entire item queue on each item add
ClosedPublic

Authored by zmike on Oct 25 2019, 7:21 AM.

Details

Summary

this is a colossal waste of time. it ends up realizing every single item
immediately even if it won't be visible, which defeats the purpose of all
the batching and viewport calculations that genlist explicitly does to
avoid exactly this type of behavior
Depends on D10521

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zmike created this revision.Oct 25 2019, 7:21 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

zmike requested review of this revision.Oct 25 2019, 7:21 AM
cedric accepted this revision.Oct 25 2019, 10:23 AM

genlist has some weird/unexplained piece of code. Hopefully this is just useless.

This revision is now accepted and ready to land.Oct 25 2019, 10:23 AM
Closed by commit rEFL0777b74f0785: elm/genlist: don't process entire item queue on each item add (authored by zmike, committed by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyOct 29 2019, 8:14 AM
This revision was automatically updated to reflect the committed changes.