Page MenuHomePhabricator

elm/genlist: remove calc jobs
ClosedPublic

Authored by zmike on Oct 25 2019, 7:21 AM.

Details

Summary

now that we have a sane and consistent sizing calc mechanism, we no longer
need to be randomly creating jobs to do additional side calcs in addition
to our other multiple bespoke calculation methods

instead, we can now call the calc function directly during the group calc
to perform all the calcs at once and avoid the overhead of constantly triggering
calc jobs

a possible future improvement here could be to remove the _calc_job() call in
the internal pan object's group_calculate, as this is likely a duplicated op
but it will require additional testing to verify

unit test performance (e.g., tree) increases roughly 50-80% after this patch
Depends on D10522

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zmike created this revision.Oct 25 2019, 7:21 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

zmike requested review of this revision.Oct 25 2019, 7:21 AM
cedric accepted this revision.Oct 25 2019, 10:24 AM

Hero move!

This revision is now accepted and ready to land.Oct 25 2019, 10:24 AM
Closed by commit rEFL712266fb9ae3: elm/genlist: remove calc jobs (authored by zmike, committed by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyOct 29 2019, 8:14 AM
This revision was automatically updated to reflect the committed changes.