elm/genlist: slightly simplify use of _item_filtered_get()
ClosedPublic
Actions

Authored by zmike on Oct 25 2019, 7:22 AM.

Details

Reviewers

Commits

rEFLb882209f8c77: elm/genlist: slightly simplify use of _item_filtered_get()
rEFL846563f13c9b: elm/genlist: slightly simplify use of _item_filtered_get()

Summary

passing the smart data here (which we always have) makes the function
a little clearer to read. similarly, we can check whether the filter_data
pointer is set inside the function to avoid having to check it everywhere else
Depends on D10524

Diff Detail

Repository

rEFL core/efl

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

zmike created this revision.Oct 25 2019, 7:22 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

zmike requested review of this revision.Oct 25 2019, 7:22 AM

zmike added a child revision: D10526: elm/genlist: trigger filter,done callback immediately if no filter queue exists.

Harbormaster completed remote builds in B14193: Diff 26391.Oct 25 2019, 7:28 AM

cedric accepted this revision.Oct 25 2019, 10:30 AM

This revision is now accepted and ready to land.Oct 25 2019, 10:30 AM

Closed by commit rEFL846563f13c9b: elm/genlist: slightly simplify use of _item_filtered_get() (authored by zmike, committed by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyOct 29 2019, 8:15 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/lib/elementary/elm_genlist.c (30 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	26391	d8cf973		Oct 25 2019, 7:22 AM	★	★
Diff 2	26496	2385180	rEFL846563f13c9b20f521b2247c54a753f5344b55e3	Oct 29 2019, 8:09 AM	★	★

Status	Author	Revision
Closed	zmike	D10546 tests/ecore: do not create global test timeout timer if running unforked
Closed	zmike	D10545 ecore/timer: correctly handle recursive deletion of legacy timers
Closed	zmike	D10531 tests/loop_timer: add port of ecore_timer behavior tests for loop_timer
Closed	zmike	D10547 tests/ecore: add intensive test for recursive timer usage
Closed	zmike	D10530 tests/ecore: make timer behavior test even more strict
Closed	zmike	D10528 tests/genlist: add behavior testing for nearly all genlist events
Closed	zmike	D10544 elm/genlist: fix item focus unregister on item move
Closed	zmike	D10543 elm/genlist: hide cached item contents and mark content unfocusable during calc
Closed	zmike	D10533 elm/genlist: set pan need recalc during item move on item position change
Closed	zmike	D10527 elm/genlist: fix "drag" smart callback
Closed	zmike	D10526 elm/genlist: trigger filter,done callback immediately if no filter queue exists
Closed	zmike	D10525 elm/genlist: slightly simplify use of _item_filtered_get()
Closed	zmike	D10524 elm/genlist: defer recalc when applying a name filter
Closed	zmike	D10523 elm/genlist: remove calc jobs
Closed	zmike	D10522 elm/genlist: don't process entire item queue on each item add
Closed	zmike	D10521 elm/genlist: freeze/thaw canvas when processing item queue
Abandoned	zmike	D10520 elm/genlist: redo focus adapter management on item blocks
Closed	zmike	D10519 elm/genlist: only add calc job on theme apply if already finalized
Closed	zmike	D10518 elm/genlist: remove misleading "changed" signal
Closed	zmike	D10517 elm/genlist: fix item highlight/unhighlight eventing on clicks
Closed	zmike	D10516 tests/ecore: add more grueling timer throughput test
Closed	zmike	D10515 efl/timer: correctly handle recursion for timer processing
Closed	zmike	D10514 efl/timer: don't attempt instantiating timers until they're finalized
Closed	zmike	D10513 tests/genlist: fix tree test sizing
Closed	zmike	D10512 tests/elm: add utility function to trigger a mouse drag
Closed	zmike	D10511 tests/elm: make argv a static char so it never goes out of scope and crashes
Closed	zmike	D10510 tests/elm: add util functions for clicking objects/parts with event flags
Closed	zmike	D10509 tests/elm: add util callback for incrementing an int data

Diff 26496

View Options

src/lib/elementary/elm_genlist.c