Page MenuHomePhabricator

tests/ecore: do not create global test timeout timer if running unforked
ClosedPublic

Authored by zmike on Oct 28 2019, 12:53 PM.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zmike created this revision.Oct 28 2019, 12:53 PM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

Doesn't this disable timeout completely when running with CK_FORK?

zmike added a comment.Oct 30 2019, 9:47 AM

Yes, it disables the timeout when forking is disabled for debugging. As the commit log states.

cedric added a subscriber: vtorri.Oct 30 2019, 10:31 AM

Hum, I am thrilled with having both behavior together as I am not sure that on windows the default is to run the tests with no CK_FORK==no. @vtorri could you clarify how libcheck behave on Windows? If it is not the case, then I am fine with this patch, if it is, it would be best to have another env used.

HAVE_FORK is not defined on windows. That's why the existing test infrastructure uses this define to verify it.

This revision is now accepted and ready to land.Oct 30 2019, 11:09 AM
This revision was automatically updated to reflect the committed changes.