tests/ecore: do not create global test timeout timer if running unforked
ClosedPublic
Actions

Authored by zmike on Oct 28 2019, 12:53 PM.

Details

Reviewers

Commits

rEFL71a52060f5a4: tests/ecore: do not create global test timeout timer if running unforked
rEFL7b374754cbb4: tests/ecore: do not create global test timeout timer if running unforked

Summary

this is a pita for debugging
Depends on D10545

Diff Detail

Repository

rEFL core/efl

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

zmike created this revision.Oct 28 2019, 12:53 PM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

Harbormaster completed remote builds in B14227: Diff 26447.Oct 28 2019, 12:53 PM

zmike requested review of this revision.Oct 28 2019, 12:53 PM

zmike added a child revision: D10547: tests/ecore: add intensive test for recursive timer usage.

zmike removed a child revision: D10547: tests/ecore: add intensive test for recursive timer usage.Oct 28 2019, 12:55 PM

Doesn't this disable timeout completely when running with CK_FORK?

Yes, it disables the timeout when forking is disabled for debugging. As the commit log states.

Hum, I am thrilled with having both behavior together as I am not sure that on windows the default is to run the tests with no CK_FORK==no. @vtorri could you clarify how libcheck behave on Windows? If it is not the case, then I am fine with this patch, if it is, it would be best to have another env used.

HAVE_FORK is not defined on windows. That's why the existing test infrastructure uses this define to verify it.

Oh!

This revision is now accepted and ready to land.Oct 30 2019, 11:09 AM

Closed by commit rEFL7b374754cbb4: tests/ecore: do not create global test timeout timer if running unforked (authored by zmike, committed by cedric). · Explain WhyOct 30 2019, 3:51 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/tests/ecore/ecore_suite.c (3 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	26447	132029c		Oct 28 2019, 12:53 PM	★	★
Diff 2	26579	9e313f1	rEFL7b374754cbb40d6fcc82556b35b92e172bf896e1	Oct 30 2019, 8:49 AM	★	★

Status	Author	Revision
Closed	zmike	D10531 tests/loop_timer: add port of ecore_timer behavior tests for loop_timer
Closed	zmike	D10547 tests/ecore: add intensive test for recursive timer usage
Closed	zmike	D10530 tests/ecore: make timer behavior test even more strict
Closed	zmike	D10528 tests/genlist: add behavior testing for nearly all genlist events
Closed	zmike	D10544 elm/genlist: fix item focus unregister on item move
Closed	zmike	D10543 elm/genlist: hide cached item contents and mark content unfocusable during calc
Closed	zmike	D10533 elm/genlist: set pan need recalc during item move on item position change
Closed	zmike	D10527 elm/genlist: fix "drag" smart callback
Closed	zmike	D10526 elm/genlist: trigger filter,done callback immediately if no filter queue exists
Closed	zmike	D10525 elm/genlist: slightly simplify use of _item_filtered_get()
Closed	zmike	D10524 elm/genlist: defer recalc when applying a name filter
Closed	zmike	D10523 elm/genlist: remove calc jobs
Closed	zmike	D10522 elm/genlist: don't process entire item queue on each item add
Closed	zmike	D10521 elm/genlist: freeze/thaw canvas when processing item queue
Abandoned	zmike	D10520 elm/genlist: redo focus adapter management on item blocks
Closed	zmike	D10519 elm/genlist: only add calc job on theme apply if already finalized
Closed	zmike	D10518 elm/genlist: remove misleading "changed" signal
Closed	zmike	D10517 elm/genlist: fix item highlight/unhighlight eventing on clicks
Closed	zmike	D10516 tests/ecore: add more grueling timer throughput test
Closed	zmike	D10546 tests/ecore: do not create global test timeout timer if running unforked
Closed	zmike	D10545 ecore/timer: correctly handle recursive deletion of legacy timers
Closed	zmike	D10515 efl/timer: correctly handle recursion for timer processing
Closed	zmike	D10514 efl/timer: don't attempt instantiating timers until they're finalized
Closed	zmike	D10513 tests/genlist: fix tree test sizing
Closed	zmike	D10512 tests/elm: add utility function to trigger a mouse drag
Closed	zmike	D10511 tests/elm: make argv a static char so it never goes out of scope and crashes
Closed	zmike	D10510 tests/elm: add util functions for clicking objects/parts with event flags
Closed	zmike	D10509 tests/elm: add util callback for incrementing an int data

Diff 26579

View Options

src/tests/ecore/ecore_suite.c