efl_canvas_animation_scale: move from 2 doubles to vectors
ClosedPublic
Actions

Authored by bu5hm4n on Oct 30 2019, 1:53 AM.

Details

Reviewers

segfaultxavi
Jaehyun_Cho

Maniphest Tasks

T8288: Animation API

Commits

rEFLe2a011f56b48: efl_canvas_animation_scale: move from 2 doubles to vectors

Summary

with this the passing of positions is getting more easy. Additionally,
Reading the API call gets easier, as parameters are semantically
grouped.
Depends on D10558

Diff Detail

Repository

rEFL core/efl

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

bu5hm4n created this revision.Oct 30 2019, 1:53 AM

Herald added a project: efl. · View Herald TranscriptOct 30 2019, 1:53 AM

Herald added subscribers: committers, reviewers, cedric. · View Herald Transcript

bu5hm4n requested review of this revision.Oct 30 2019, 1:53 AM

bu5hm4n added a child revision: D10560: efl_canvas_animation: improve generally.

Harbormaster completed remote builds in B14259: Diff 26524.Oct 30 2019, 1:54 AM

Yup, much nicer.
These docs are already scheduled for reviewing so typos and formatting will be taken care of later in T7717.

This revision is now accepted and ready to land.Oct 30 2019, 2:12 AM

bu5hm4n added a task: T8288: Animation API.Oct 30 2019, 3:01 AM

bu5hm4n added a child revision: D10562: efl_canvas_animation_translate: move from x&y to container types.Oct 30 2019, 3:01 AM

Closed by commit rEFLe2a011f56b48: efl_canvas_animation_scale: move from 2 doubles to vectors (authored by Marcel Hollerbach <mail@marcel-hollerbach.de>, committed by segfaultxavi). · Explain WhyNov 4 2019, 4:20 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/bin/elementary/test_efl_anim_group_parallel.c (4 lines)
M			src/bin/elementary/test_efl_anim_group_sequential.c (4 lines)
M			src/bin/elementary/test_efl_anim_scale.c (12 lines)
M			src/lib/evas/canvas/efl_canvas_animation_scale.c (134 lines)
M			src/lib/evas/canvas/efl_canvas_animation_scale.eo (20 lines)
M			src/lib/evas/canvas/efl_canvas_animation_scale_private.h (18 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	26524	fa31bf6		Oct 30 2019, 1:52 AM	★	★
Diff 2	26662	92a4fab	rEFLe2a011f56b48d7894e710fca5a46a4bfe87ecd1f	Nov 4 2019, 4:06 AM	★	★

Status	Author	Revision
Closed	segfaultxavi	D10565 docs: Polish Efl.Canvas.Animation_*
Closed	bu5hm4n	D10562 efl_canvas_animation_translate: move from x&y to container types
Closed	segfaultxavi	D10560 efl_canvas_animation: improve generally
Closed	bu5hm4n	D10559 efl_canvas_animation_scale: move from 2 doubles to vectors
Closed	bu5hm4n	D10558 efl_canvas_animation: be more explicit with errors
Closed	bu5hm4n	D10350 efl_canvas_animation_rotate: adjust API