Page MenuHomePhabricator

csharp: Removing a never used class.
ClosedPublic

Authored by brunobelo on Nov 6 2019, 11:31 AM.

Diff Detail

Repository
rEFL core/efl
Branch
arcpatch-D10611
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 14398
Build 9915: arc lint + arc unit
brunobelo created this revision.Nov 6 2019, 11:31 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

brunobelo requested review of this revision.Nov 6 2019, 11:31 AM
segfaultxavi requested changes to this revision.Nov 7 2019, 1:42 AM
segfaultxavi added a subscriber: segfaultxavi.

We don't like commented-out code. Either remove it completely, or use it, or, at the very least, add a comment saying why it is commented out (and you better have a very good reason) :)

This revision now requires changes to proceed.Nov 7 2019, 1:42 AM

@segfaultxavi i just followed the flow, in the same file, other classes was commented.

Yeah, but they have comments explaining why they are commented.
So, unless you have a good explanation why that empty class must remain there... Kill With Fire!

brunobelo retitled this revision from csharp: Commenting a never used class. to csharp: Removing a never used class..Nov 7 2019, 10:27 AM
segfaultxavi accepted this revision.Nov 7 2019, 10:59 AM

All good!

This revision is now accepted and ready to land.Nov 7 2019, 10:59 AM
This revision was automatically updated to reflect the committed changes.