Page MenuHomePhabricator
Differential D10612

csharp: Iterate more in GC-dependent test
ClosedPublic
Actions

Authored by lauromoura on Nov 6 2019, 11:34 AM.

Details

Reviewers
stefan_schmidt
brunobelo
felipealmeida
Maniphest Tasks
T8313: Failed mono testsuite on CI
Commits
rEFLaacd2fa82d68: csharp: Iterate more in GC-dependent test
Summary

The inheritance test depends on the objects being actively destroyed.
Currently this happens in a two step process, where first the C#
object is collected from the GC. As this happens in a separate thread,
we schedule a callback to run in the main loop to actually unref the
EO object.

This commit adds more iterations to make sure the EO of the parent is
unref'd and releases the child.

This should be the last C#-related CI test failure

Ref T8313

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
lauromoura created this revision.Nov 6 2019, 11:34 AM
lauromoura requested review of this revision.Nov 6 2019, 11:34 AM
felipealmeida accepted this revision.Nov 25 2019, 9:03 AM
This revision is now accepted and ready to land.Nov 25 2019, 9:03 AM
Closed by commit rEFLaacd2fa82d68: csharp: Iterate more in GC-dependent test (authored by lauromoura). · Explain WhyNov 26 2019, 8:01 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/tests/efl_mono/Inheritance.cs (6 lines)

Diff 27124

View Options

src/tests/efl_mono/Inheritance.cs

Loading...