| kwo |
implemented 8 bit color mapped images with 24/32bpp palette.
This is coming from an issue on feh to support indexed TGA images. Written by rofl0r, I'm forwarding it because I already have the tools for submission set up.
N.b. I'm not terribly familiar with the particular code style, if there's anything to format differently I'm happy to update.
| No Linters Available |
| No Unit Test Coverage |
| Buildable 14495 | |
| Build 9970: arc lint + arc unit |
Looks good to me except that all of the error exits need proper cleanup (munmap(), __imlib_FreeData()).
I have made some cleanups in the tga loader so now you should just goto quit on error.
I have also eliminated the somewhat nasty WRITE_RGBA() macro - please use PIXEL_ARGB instead.
As for indentation - I use indent (version 2.2.12 - matters!), there is an .indent.pro in the top level directory, so you can just do like
$ indent src/modules/loaders/loader_tga.c
But no problem - I'm fine with amending the indent.
Could you please redo your changes (with proper exit handling etc.) on top of mine?
Thanks! :)
Cool, thanks; rofl0r did do so, I'm just forwarding their changes again; I ran indent as well, but committed that as a separate commit because of the IMO questionable change on the line break. Hope this looks good then.