Page MenuHomePhabricator

elm_entry: fix wrong displayed scrollbars
ClosedPublic

Authored by bu5hm4n on Nov 7 2019, 12:49 PM.

Details

Summary

the scrolbars have been displayed wrongly before. Reason for this is
that the theme displays the bars per default, the code however works
with hidden by default. This was worked arround before with the fact
that we are explicitly hiding the vbar/hbar before.
The reason this previous code was not working proberly is that entry
decided to retheme a object that was already set to the interface
scrollable object. Which means, it was not detected by the code. With
the newly introduced reset function you can tell the interface, that you
have changed the group, signals will be emitted accordingly.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bu5hm4n created this revision.Nov 7 2019, 12:49 PM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

bu5hm4n requested review of this revision.Nov 7 2019, 12:49 PM
cedric accepted this revision.Nov 7 2019, 1:08 PM

It actually does make sense once you are pointing it out.

This revision is now accepted and ready to land.Nov 7 2019, 1:08 PM
Closed by commit rEFL01bf9a34d667: elm_entry: fix wrong displayed scrollbars (authored by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyNov 7 2019, 1:25 PM
This revision was automatically updated to reflect the committed changes.