Page MenuHomePhabricator

efl_canvas_vg_node: Prevent access to NULL object for remove warning
ClosedPublic

Authored by jsuya on Thu, Nov 7, 11:17 PM.

Details

Summary

For remove this warning
WRN<3378>:eo ../src/lib/eo/eo.c:644 _efl_object_call_resolve() NULL passed to function efl_invalidated_get().

Test Plan

elementary_test -> animation_view

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
jsuya created this revision.Thu, Nov 7, 11:17 PM
jsuya requested review of this revision.Thu, Nov 7, 11:17 PM
Hermet requested changes to this revision.Mon, Nov 11, 4:17 PM
Hermet added inline comments.
src/lib/evas/canvas/efl_canvas_vg_node.c
33

guess how vg_obj is null here but if it's necessary, it must be like this:

if (!nd->vg_obj || efl_invalidated_get(nd->vg_obj));

This revision now requires changes to proceed.Mon, Nov 11, 4:17 PM
jsuya updated this revision to Diff 26819.Mon, Nov 11, 9:53 PM

update patch

Hermet accepted this revision.Wed, Nov 13, 5:52 PM
This revision is now accepted and ready to land.Wed, Nov 13, 5:52 PM
This revision was automatically updated to reflect the committed changes.