Page MenuHomePhabricator

evas proxy: make it work for File_Save.save
Needs ReviewPublic

Authored by kimcinoo on Nov 8 2019, 2:31 AM.

Details

Summary

File_Save.save does not work for proxy object from following commit.

c53f152 evas: Make save() work on snapshots
Test Plan
  1. Add an image object and set source object.

evas_object_image_source_set(obj, source);

  1. Save the object as a file when you need.

evas_object_image_save(obj, "./file_name.png", NULL, NULL);

Diff Detail

Repository
rEFL core/efl
Branch
evas.proxy_work.for.file.save
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 15261
Build 10520: arc lint + arc unit
kimcinoo created this revision.Nov 8 2019, 2:31 AM
kimcinoo requested review of this revision.Nov 8 2019, 2:31 AM
kimcinoo updated this revision to Diff 26766.Nov 8 2019, 2:40 AM

Go right way to fix issue.

kimcinoo edited the test plan for this revision. (Show Details)Nov 8 2019, 2:43 AM

Previously, was this feature was supported correctly?

Seems very dangerous with only this change, Need to clarify more scenarios...

kimcinoo added a comment.EditedNov 11 2019, 5:22 PM

Previously, was this feature was supported correctly?

Sure I think so. This is regression issue reported by an user.

Seems very dangerous with only this change, Need to clarify more scenarios...

The needs_post_render is TRUE only when _efl_canvas_image_internal_efl_file_save_save calls _evas_image_pixels_get
Otherwise it is FALSE.

zmike added a subscriber: zmike.Mon, Dec 23, 6:47 AM

This seems sane to me, but could we add a brief unit test (just throw e.g., a red rectangle into an image, proxy+save it, then open+scan the pixels) to ensure this works in the future?

Ok. Let me try.

kimcinoo updated this revision to Diff 28002.Tue, Jan 7, 10:17 PM

Add a test case to save proxy image as a file and check it with source image.