Page MenuHomePhabricator

evas proxy: make it work for File_Save.save
Needs ReviewPublic

Authored by kimcinoo on Fri, Nov 8, 2:31 AM.

Details

Summary

File_Save.save does not work for proxy object from following commit.

c53f152 evas: Make save() work on snapshots
Test Plan
  1. Add an image object and set source object.

evas_object_image_source_set(obj, source);

  1. Save the object as a file when you need.

evas_object_image_save(obj, "./file_name.png", NULL, NULL);

Diff Detail

Repository
rEFL core/efl
Branch
evas.proxy_work.for.file.save
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 14414
Build 9922: arc lint + arc unit
kimcinoo created this revision.Fri, Nov 8, 2:31 AM
kimcinoo requested review of this revision.Fri, Nov 8, 2:31 AM
kimcinoo updated this revision to Diff 26766.Fri, Nov 8, 2:40 AM

Go right way to fix issue.

kimcinoo edited the test plan for this revision. (Show Details)Fri, Nov 8, 2:43 AM

Previously, was this feature was supported correctly?

Seems very dangerous with only this change, Need to clarify more scenarios...

kimcinoo added a comment.EditedMon, Nov 11, 5:22 PM

Previously, was this feature was supported correctly?

Sure I think so. This is regression issue reported by an user.

Seems very dangerous with only this change, Need to clarify more scenarios...

The needs_post_render is TRUE only when _efl_canvas_image_internal_efl_file_save_save calls _evas_image_pixels_get
Otherwise it is FALSE.