Page MenuHomePhabricator

ecore: correctly apply the offset on the upper part of the boolean mask for Efl.BooleanModel.
ClosedPublic

Authored by cedric on Fri, Nov 8, 12:16 PM.

Details

Summary

The upper mask is the one that should actually move as the gap is between the lower and
the upper mask when removing an element from the array.

Depends on D10631

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
cedric created this revision.Fri, Nov 8, 12:16 PM
bu5hm4n accepted this revision.Sun, Nov 10, 4:04 AM

Why did this never show up in any test ?

This revision is now accepted and ready to land.Sun, Nov 10, 4:04 AM

Because their wasn't a test for it until now ๐Ÿ˜“

cedric updated this revision to Diff 26855.Wed, Nov 13, 9:19 AM
cedric edited the summary of this revision. (Show Details)

rebase

Closed by commit rEFLd505167d68e7: ecore: correctly apply the offset on the upper part of the boolean mask for Efl. (authored by cedric, committed by Marcel Hollerbach <mail@marcel-hollerbach.de>). ยท Explain WhyWed, Nov 13, 12:18 PM
This revision was automatically updated to reflect the committed changes.