Page MenuHomePhabricator

efl: improve Efl.BooleanModel test by checking the child del case.
ClosedPublic

Authored by cedric on Fri, Nov 8, 12:16 PM.

Details

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
cedric created this revision.Fri, Nov 8, 12:16 PM
cedric requested review of this revision.Fri, Nov 8, 12:16 PM
bu5hm4n requested changes to this revision.Sun, Nov 10, 5:04 AM
bu5hm4n added inline comments.
src/tests/efl/efl_test_composite_model.c
154

Does not even compile for me o.O

This revision now requires changes to proceed.Sun, Nov 10, 5:04 AM
cedric added inline comments.Sun, Nov 10, 12:32 PM
src/tests/efl/efl_test_composite_model.c
154

How so?

This is the test you're looking for.

The assert is not found ...

The assert is not found ...

At link time? The header is there, so I am guessing your problem is not a compile time.

lauromoura added inline comments.Wed, Nov 13, 5:47 AM
src/tests/efl/efl_test_composite_model.c
154

There shouldn't be something inside this assert?

In file included from ../src/tests/efl/efl_test_composite_model.c:28:
../src/tests/efl/efl_test_composite_model.c: In function ‘_assert_on_error’:
../src/tests/efl/efl_test_composite_model.c:156:4: error: expected expression before ‘)’ token
    assert();
    ^~~~~~
cedric planned changes to this revision.Wed, Nov 13, 7:22 AM
cedric added inline comments.
src/tests/efl/efl_test_composite_model.c
154

Dah! Thank you. I wanted to use abort. Why is it even working for me!

cedric updated this revision to Diff 26857.Wed, Nov 13, 9:20 AM
cedric edited the summary of this revision. (Show Details)

rebase and fix assert.

bu5hm4n accepted this revision.Wed, Nov 13, 12:01 PM

Why did that compile for you ? o.O Works for me now.

This revision is now accepted and ready to land.Wed, Nov 13, 12:02 PM
Closed by commit rEFL6befb6e17bf4: efl: improve Efl.BooleanModel test by checking the child del case. (authored by cedric, committed by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyWed, Nov 13, 12:18 PM
This revision was automatically updated to reflect the committed changes.