Page MenuHomePhabricator

efl_ui_spotlight_manager stack: move away from player object
ClosedPublic

Authored by bu5hm4n on Nov 10 2019, 2:14 PM.

Details

Summary

with this commit we move from using the player object to using the mixin
that was introduced a few commits before. The new mixin is way easier to
use here, we safe a lot of code, we also only need 1 object instead of

  1. (And overall, everything just gets sooooo much more easier).

Depends on D10636

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bu5hm4n created this revision.Nov 10 2019, 2:14 PM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

bu5hm4n requested review of this revision.Nov 10 2019, 2:14 PM
bu5hm4n updated this revision to Diff 26846.Wed, Nov 13, 7:21 AM
bu5hm4n edited the summary of this revision. (Show Details)

rename

bu5hm4n updated this revision to Diff 26892.Thu, Nov 14, 3:55 AM

finalize player removal

cedric accepted this revision.Fri, Nov 15, 11:34 AM
This revision is now accepted and ready to land.Fri, Nov 15, 11:34 AM
Closed by commit rEFLd4c004ab5db3: efl_ui_spotlight_manager stack: move away from player object (authored by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyWed, Nov 20, 1:05 AM
This revision was automatically updated to reflect the committed changes.