Page MenuHomePhabricator

efl_ui_relative_container: rename relative_layout
ClosedPublic

Authored by YOhoho on Sun, Nov 10, 9:39 PM.

Details

Summary

Also,
Rename parameter name target to base.
Rename parameter name relative to relative_position.

ref T8380

Depends On D10639

Test Plan

ninja test

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
YOhoho created this revision.Sun, Nov 10, 9:39 PM
YOhoho requested review of this revision.Sun, Nov 10, 9:39 PM
YOhoho updated this revision to Diff 26794.Sun, Nov 10, 9:43 PM
YOhoho edited the summary of this revision. (Show Details)

Update commit message.

I have just some documentation comments, and everything looks fine for me!

src/lib/elementary/efl_ui_relative_container.eo
10

I suggest this text:

Specifies the left side edge of the $child object relative to the $base object.
When $relative_position is 0 the left edges of the two objects are aligned.
When $relative_position is 1 the left edge of the $child object is aligned to the right edge of the $base object.

Explanations about the default values are given in each value's documentation.

Same comments for the other properties.

13
The child object whose size and position is being changed.
16

I would explicit the default value in EO format.

base: Efl.Gfx.Entity(null); [[The object whose size and position is being used as reference.
                              The default value means that the container object is used.]]
YOhoho added inline comments.Mon, Nov 11, 7:41 PM
src/lib/elementary/efl_ui_relative_container.eo
16

I'm not sure that null is okay as default value.
Default value is relative_container(parent of child), but NULL parameter means that i don't want to change base.

Eo *base;
Eo *btn1 = efl_add(EFL_UI_BUTTON_CLASS, layout);
efl_ui_relative_container_relation_right_set(layout, btn1, NULL, 0.0);
efl_ui_relative_container_relation_right_get(layout, btn1, &base, NULL);

printf("layout : %p, base : %p\n", layout, base);

== > layout : 0x40000002703c, base : 0x40000002703c
base is not NULL..

YOhoho updated this revision to Diff 26814.Mon, Nov 11, 7:44 PM

Update documentation.

segfaultxavi requested changes to this revision.Mon, Nov 11, 11:55 PM

Please use the same updated docs for all properties (left, right, top, bottom).

src/lib/elementary/efl_ui_relative_container.eo
16

OK, don't use null as the default value. But use these docs then:

base: Efl.Gfx.Entity; [[The object whose size and position is being used as reference.
                        $NULL means that the container object is used
                        (this is the default value).]]
This revision now requires changes to proceed.Mon, Nov 11, 11:55 PM
YOhoho updated this revision to Diff 26824.Tue, Nov 12, 12:14 AM

Update base parameter docs.

segfaultxavi requested changes to this revision.Tue, Nov 12, 2:29 AM

Please read my comment carefully. This makes no sense and it is not what I wrote:

The default value means that the container object is used (this is the default value).
This revision now requires changes to proceed.Tue, Nov 12, 2:29 AM
YOhoho updated this revision to Diff 26826.Tue, Nov 12, 4:33 AM

Oops, fix wrong docs..

segfaultxavi accepted this revision.Tue, Nov 12, 4:53 AM

All good!

This revision is now accepted and ready to land.Tue, Nov 12, 4:53 AM
Closed by commit rEFL246485ca928d: efl_ui_relative_container: rename relative_layout (authored by Yeongjong Lee <yj34.lee@samsung.com>, committed by segfaultxavi). · Explain WhyTue, Nov 12, 5:33 AM
This revision was automatically updated to reflect the committed changes.