Details
Details
- Reviewers
woohyun segfaultxavi - Maniphest Tasks
- T8380: efl.ui.relative_layout
- Commits
- rEFL246485ca928d: efl_ui_relative_container: rename relative_layout
ninja test
Diff Detail
Diff Detail
- Repository
- rEFL core/efl
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 14440 Build 9935: arc lint + arc unit
Comment Actions
I have just some documentation comments, and everything looks fine for me!
src/lib/elementary/efl_ui_relative_container.eo | ||
---|---|---|
10–11 | I suggest this text: Specifies the left side edge of the $child object relative to the $base object. When $relative_position is 0 the left edges of the two objects are aligned. When $relative_position is 1 the left edge of the $child object is aligned to the right edge of the $base object. Explanations about the default values are given in each value's documentation. Same comments for the other properties. | |
13 | The child object whose size and position is being changed. | |
16–18 | I would explicit the default value in EO format. base: Efl.Gfx.Entity(null); [[The object whose size and position is being used as reference. The default value means that the container object is used.]] |
src/lib/elementary/efl_ui_relative_container.eo | ||
---|---|---|
16–18 | I'm not sure that null is okay as default value. Eo *base; Eo *btn1 = efl_add(EFL_UI_BUTTON_CLASS, layout); efl_ui_relative_container_relation_right_set(layout, btn1, NULL, 0.0); efl_ui_relative_container_relation_right_get(layout, btn1, &base, NULL); printf("layout : %p, base : %p\n", layout, base); == > layout : 0x40000002703c, base : 0x40000002703c |
Comment Actions
Please use the same updated docs for all properties (left, right, top, bottom).
src/lib/elementary/efl_ui_relative_container.eo | ||
---|---|---|
16–18 | OK, don't use null as the default value. But use these docs then: base: Efl.Gfx.Entity; [[The object whose size and position is being used as reference. $NULL means that the container object is used (this is the default value).]] |
Comment Actions
Please read my comment carefully. This makes no sense and it is not what I wrote:
The default value means that the container object is used (this is the default value).