Details

Reviewers

woohyun
segfaultxavi

Maniphest Tasks

T8380: efl.ui.relative_layout

Commits

rEFL246485ca928d: efl_ui_relative_container: rename relative_layout

Summary

Also,
Rename parameter name target to base.
Rename parameter name relative to relative_position.

ref T8380

Depends On D10639

Test Plan

ninja test

Diff Detail

Repository

rEFL core/efl

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 14440
Build 9935: arc lint + arc unit

YOhoho created this revision.Nov 10 2019, 9:39 PM

Herald added a project: efl. · View Herald TranscriptNov 10 2019, 9:39 PM

Herald added subscribers: committers, reviewers, cedric. · View Herald Transcript

YOhoho requested review of this revision.Nov 10 2019, 9:39 PM

Harbormaster completed remote builds in B14440: Diff 26793.Nov 10 2019, 9:39 PM

D10639 is needed to fix C# build error.

Update commit message.

Harbormaster completed remote builds in B14441: Diff 26794.Nov 10 2019, 9:43 PM

I have just some documentation comments, and everything looks fine for me!

src/lib/elementary/efl_ui_relative_container.eo
10–11	I suggest this text: Specifies the left side edge of the $child object relative to the $base object. When $relative_position is 0 the left edges of the two objects are aligned. When $relative_position is 1 the left edge of the $child object is aligned to the right edge of the $base object. Explanations about the default values are given in each value's documentation. Same comments for the other properties.
13	The child object whose size and position is being changed.
16–18	I would explicit the default value in EO format. base: Efl.Gfx.Entity(null); [[The object whose size and position is being used as reference. The default value means that the container object is used.]]

src/lib/elementary/efl_ui_relative_container.eo

10–11

I suggest this text:

Specifies the left side edge of the $child object relative to the $base object.
When $relative_position is 0 the left edges of the two objects are aligned.
When $relative_position is 1 the left edge of the $child object is aligned to the right edge of the $base object.

Explanations about the default values are given in each value's documentation.

Same comments for the other properties.

The child object whose size and position is being changed.

16–18

I would explicit the default value in EO format.

base: Efl.Gfx.Entity(null); [[The object whose size and position is being used as reference.
                              The default value means that the container object is used.]]

segfaultxavi mentioned this in D10641: elementary: stabilize Efl.Ui.Relative_Container.Nov 11 2019, 2:16 AM

segfaultxavi added a child revision: D10641: elementary: stabilize Efl.Ui.Relative_Container.

YOhoho added inline comments.Nov 11 2019, 7:41 PM

src/lib/elementary/efl_ui_relative_container.eo
16–18	I'm not sure that `null` is okay as default value. Default value is relative_container(parent of child), but `NULL` parameter means that i don't want to change `base`. Eo base; Eo btn1 = efl_add(EFL_UI_BUTTON_CLASS, layout); efl_ui_relative_container_relation_right_set(layout, btn1, NULL, 0.0); efl_ui_relative_container_relation_right_get(layout, btn1, &base, NULL); printf("layout : %p, base : %p\n", layout, base); == > `layout : 0x40000002703c, base : 0x40000002703c` base is not NULL..

Update documentation.

Harbormaster completed remote builds in B14457: Diff 26814.Nov 11 2019, 7:44 PM

Please use the same updated docs for all properties (left, right, top, bottom).

src/lib/elementary/efl_ui_relative_container.eo
16–18	OK, don't use `null` as the default value. But use these docs then: base: Efl.Gfx.Entity; [[The object whose size and position is being used as reference. $NULL means that the container object is used (this is the default value).]]

This revision now requires changes to proceed.Nov 11 2019, 11:55 PM

Update base parameter docs.

Harbormaster completed remote builds in B14462: Diff 26824.Nov 12 2019, 12:15 AM

Please read my comment carefully. This makes no sense and it is not what I wrote:

The default value means that the container object is used (this is the default value).

This revision now requires changes to proceed.Nov 12 2019, 2:29 AM

Oops, fix wrong docs..

Harbormaster completed remote builds in B14464: Diff 26826.Nov 12 2019, 4:33 AM

All good!

This revision is now accepted and ready to land.Nov 12 2019, 4:53 AM

Closed by commit rEFL246485ca928d: efl_ui_relative_container: rename relative_layout (authored by Yeongjong Lee <yj34.lee@samsung.com>, committed by segfaultxavi). · Explain WhyNov 12 2019, 5:33 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/bin/elementary/meson.build (2 lines)
M			src/bin/elementary/test.c (4 lines)
V			src/bin/elementary/{test_ui_relative_container.c ← test_ui_relative_layout.c} (50 lines)
V			src/bin/elementary/{test_ui_relative_layout.c → test_ui_relative_container.c}
M			src/examples/elementary/.gitignore (4 lines)
V			src/examples/elementary/{efl_ui_relative_container_example_01.c ← efl_ui_relative_layout_example_01.c} (18 lines)
V			src/examples/elementary/{efl_ui_relative_container_example_02.c ← efl_ui_relative_layout_example_02.c} (14 lines)
V			src/examples/elementary/{efl_ui_relative_layout_example_01.c → efl_ui_relative_container_example_01.c}
V			src/examples/elementary/{efl_ui_relative_layout_example_02.c → efl_ui_relative_container_example_02.c}
M			src/lib/elementary/Efl_Ui.h (2 lines)
V			src/lib/elementary/{efl_ui_relative_container.c ← efl_ui_relative_layout.c} (198 lines)
V			src/lib/elementary/{efl_ui_relative_container.eo ← efl_ui_relative_layout.eo} (46 lines)
V			src/lib/elementary/{efl_ui_relative_container_private.h ← efl_ui_relative_layout_private.h} (68 lines)
V			src/lib/elementary/{efl_ui_relative_layout.c → efl_ui_relative_container.c}
V			src/lib/elementary/{efl_ui_relative_layout.eo → efl_ui_relative_container.eo}
V			src/lib/elementary/{efl_ui_relative_layout_private.h → efl_ui_relative_container_private.h}
M			src/lib/elementary/meson.build (6 lines)
M			src/tests/elementary/efl_ui_suite.h (2 lines)
M			src/tests/elementary/efl_ui_suite.c (2 lines)
V			src/tests/elementary/{efl_ui_test_relative_container.c ← efl_ui_test_relative_layout.c} (58 lines)
V			src/tests/elementary/{efl_ui_test_relative_layout.c → efl_ui_test_relative_container.c}
M			src/tests/elementary/meson.build (2 lines)
M			src/tests/elementary/spec/efl_test_basics.c (2 lines)
M			src/tests/elementary/spec/efl_test_pack.c (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	26793	22dfc78		Nov 10 2019, 9:39 PM	★	★
Diff 2	26794	22dfc78	Update commit message.	Nov 10 2019, 9:43 PM	★	★
Diff 3	26814	fd8a5c5	Update documentation.	Nov 11 2019, 7:44 PM	★	★
Diff 4	26824	fd8a5c5	Update `base` parameter docs.	Nov 12 2019, 12:14 AM	★	★
Diff 5	26826	82f00f1	Oops, fix wrong docs..	Nov 12 2019, 4:33 AM	★	★
Diff 6	26830	a5daa2b	rEFL246485ca928d26144ca3188d895bb7b44a73d3ad	Nov 12 2019, 5:33 AM	★	★

efl_ui_relative_container: rename relative_layout
ClosedPublic
Actions

Details

Diff Detail

Revision Contents
Changeset List

Diff 26793

src/bin/elementary/meson.build

src/bin/elementary/test.c

src/bin/elementary/test_ui_relative_container.c

src/bin/elementary/test_ui_relative_layout.c

src/examples/elementary/.gitignore

src/examples/elementary/efl_ui_relative_container_example_01.c

src/examples/elementary/efl_ui_relative_container_example_02.c

src/examples/elementary/efl_ui_relative_layout_example_01.c

src/examples/elementary/efl_ui_relative_layout_example_02.c

src/lib/elementary/Efl_Ui.h

src/lib/elementary/efl_ui_relative_container.c

src/lib/elementary/efl_ui_relative_container.eo

src/lib/elementary/efl_ui_relative_container_private.h

src/lib/elementary/efl_ui_relative_layout.c

src/lib/elementary/efl_ui_relative_layout.eo

src/lib/elementary/efl_ui_relative_layout_private.h

src/lib/elementary/meson.build

src/tests/elementary/efl_ui_suite.h

src/tests/elementary/efl_ui_suite.c

src/tests/elementary/efl_ui_test_relative_container.c

src/tests/elementary/efl_ui_test_relative_layout.c

src/tests/elementary/meson.build

src/tests/elementary/spec/efl_test_basics.c

src/tests/elementary/spec/efl_test_pack.c

efl_ui_relative_container: rename relative_layoutClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 26793

src/bin/elementary/meson.build

src/bin/elementary/test.c

src/bin/elementary/test_ui_relative_container.c

src/bin/elementary/test_ui_relative_layout.c

src/examples/elementary/.gitignore

src/examples/elementary/efl_ui_relative_container_example_01.c

src/examples/elementary/efl_ui_relative_container_example_02.c

src/examples/elementary/efl_ui_relative_layout_example_01.c

src/examples/elementary/efl_ui_relative_layout_example_02.c

src/lib/elementary/Efl_Ui.h

src/lib/elementary/efl_ui_relative_container.c

src/lib/elementary/efl_ui_relative_container.eo

src/lib/elementary/efl_ui_relative_container_private.h

src/lib/elementary/efl_ui_relative_layout.c

src/lib/elementary/efl_ui_relative_layout.eo

src/lib/elementary/efl_ui_relative_layout_private.h

src/lib/elementary/meson.build

src/tests/elementary/efl_ui_suite.h

src/tests/elementary/efl_ui_suite.c

src/tests/elementary/efl_ui_test_relative_container.c

src/tests/elementary/efl_ui_test_relative_layout.c

src/tests/elementary/meson.build

src/tests/elementary/spec/efl_test_basics.c

src/tests/elementary/spec/efl_test_pack.c

efl_ui_relative_container: rename relative_layout
ClosedPublic
Actions

Revision Contents
Changeset List