Page MenuHomePhabricator

eo: do not over compute the hash when propagating events.
ClosedPublic

Authored by cedric on Wed, Nov 13, 4:08 PM.

Details

Summary

This should slightly improve speed in theory. In practice, I have not seen
a benchmark which would budge by 5%, so I am not sure it improve speed that
much.

Depends on D10659

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
cedric created this revision.Wed, Nov 13, 4:08 PM
cedric requested review of this revision.Wed, Nov 13, 4:08 PM
q66 requested changes to this revision.Wed, Nov 13, 6:50 PM

Still makes edje_cc hang, after introduction of 7f53d9158395504151e1ff3dcae715a799d913a8.

This revision now requires changes to proceed.Wed, Nov 13, 6:50 PM
q66 added a comment.Wed, Nov 13, 7:24 PM

Well, I fixed the root cause: 9ca573f40f1065cc717c0c5aabb787671bab852b

Feel free to apply your changes or whatever, shouldn't matter much. For D10659 I'd keep it as an int tbh, for this one, dunno how much value there is, same for D10658.

cedric updated this revision to Diff 26899.Thu, Nov 14, 9:33 AM
cedric edited the summary of this revision. (Show Details)

rebase

bu5hm4n added inline comments.Sun, Nov 17, 3:02 AM
src/lib/eo/eo_base_class.c
1285

I think in this block you also do not have to update the hash ?

bu5hm4n accepted this revision.Sun, Nov 17, 3:06 AM
bu5hm4n added inline comments.
src/lib/eo/eo_base_class.c
1285

NVM, we would need more logic then in the callback_call case ... lets look if we really need this later on.

This revision was not accepted when it landed; it landed in state Needs Review.Sun, Nov 17, 3:12 AM
Closed by commit rEFL75301b3a1abf: eo: do not over compute the hash when propagating events. (authored by cedric, committed by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain Why
This revision was automatically updated to reflect the committed changes.