Page MenuHomePhabricator

Revert "elm/genlist: remove calc jobs"
ClosedPublic

Authored by SanghyeonLee on Thu, Nov 14, 1:40 AM.

Details

Summary
Test Plan

run elementary_test -> genlist2

add more items by + and before/after button.

if you delete selected items by click - button,
issue cases, you can see item area become empty and not filled.

if you click U button, so update items,
issue cases, all item disappeared.

the issue is caused by removing calc_job,
so there is no job to performed,
and loof is idled states.

in Tizen,
to solving this problem,
we add dummy job in recalc cases.

Need to see how to solve the issue more simply,
but firstly raise the ticket to notify severe issue.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
SanghyeonLee created this revision.Thu, Nov 14, 1:40 AM
SanghyeonLee requested review of this revision.Thu, Nov 14, 1:40 AM

more right way of reverting it is revert elm/genlist: defer recalc when applying a name filter either

zmike added a comment.Wed, Nov 27, 6:12 AM

This should be resolved by D10752

zmike accepted this revision.Wed, Nov 27, 6:41 AM

I'm going to land this in stable.

This revision is now accepted and ready to land.Wed, Nov 27, 6:41 AM
This revision was automatically updated to reflect the committed changes.

This has already landed but it is generating new build warnings.

src/lib/elementary/elm_genlist.c
4053

I get a warning now because changed is never used. This is suspicious.
If changed is really not needed please remove the variable completely.